Skip to content

Add -FromUnixTime to Get-Date to allow Unix time input #12179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 11 commits into from
Apr 7, 2020
Merged

Add -FromUnixTime to Get-Date to allow Unix time input #12179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3953854
Add FromUnixTime switch
jackdcasey Mar 23, 2020
991a120
Add FromUnixTime tests
jackdcasey Mar 23, 2020
2017994
Address typos in documentation text
jackdcasey Mar 23, 2020
e951a6d
Remove unnecessary function creation
jackdcasey Mar 23, 2020
db60790
Consolidate tests into existing Describe block
jackdcasey Mar 23, 2020
1aa1468
Update comment for clarity
jackdcasey Mar 23, 2020
37d22a1
Add comments to outline test constants
jackdcasey Apr 5, 2020
8e9da41
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
jackdcasey Apr 5, 2020
18d7bc3
Specify UTC DateTime kind in tests
jackdcasey Apr 6, 2020
c76eebe
Specify kind as UTC if set with ticks or Unix time
jackdcasey Apr 6, 2020
9c0b42d
Revert "Specify kind as UTC if set with ticks or Unix time"
jackdcasey Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ public DateTime Date
}
}

/// <summary>
/// Gets or sets whether to treat a numeric input as ticks, or unix time.
/// </summary>
[Parameter]
public SwitchParameter FromUnixTime;

private DateTime _date;
private bool _dateSpecified;

Expand Down Expand Up @@ -237,7 +243,14 @@ protected override void ProcessRecord()
// use passed date object if specified
if (_dateSpecified)
{
dateToUse = Date;
if (FromUnixTime.IsPresent)
{
dateToUse = DateTimeOffset.FromUnixTimeSeconds(Date.Ticks).UtcDateTime;
}
else
{
dateToUse = Date;
}
}

// use passed year if specified
Expand Down
9 changes: 9 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Date.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,15 @@ Describe "Get-Date" -Tags "CI" {
$timeDifference.Milliseconds | Should -BeLessThan 1
$timeDifference.Ticks | Should -BeLessThan 10000
}

It "-FromUnixTime works" {

# Test conversion of arbitrary date in Unix time: 2020-01-01​T00:00:00.000Z
Get-Date -Date 1577836800 -FromUnixTime | Should -Be (Get-Date -Date 637134336000000000 -AsUTC)

# Test converstion of Unix time start date: 1970-01-01​T00:00:00.000Z
Get-Date -Date 0 -FromUnixTime | Should -Be (Get-Date -Date 621355968000000000 -AsUTC)
}
}

Describe "Get-Date -UFormat tests" -Tags "CI" {
Expand Down