Skip to content

Conversation

@krishnayalavarthi
Copy link
Contributor

@krishnayalavarthi krishnayalavarthi commented Mar 20, 2020

PR Summary

PR Context

This PR helps to fix this issue that I raised. Path is not parsed correctly if '[' is present in the path #12168

Issues fixed:
Having '[' character in directory doesn't work.

Create a directory: e:[test
Repro 1:
Test-Path 'e:[test'
Output: Error
Expected Output: True

Repro 2:
Test-Path "e:`[test"
Output: Error
Expected Output: True

PR Checklist

@SteveL-MSFT SteveL-MSFT added Breaking-Change breaking change that may affect users Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Mar 21, 2020
Copy link
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should add tests for examples where behaviour has changed.

Also we should consider it with respect to the discussion and work done in #7399

@kwkam
Copy link
Contributor

kwkam commented Mar 21, 2020

This PR should add tests for examples where behaviour has changed.

Also we should consider it with respect to the discussion and work done in #7399

Actually it is #7407 which is split from #5896, 2 years ago

Edit: My bad, that is a different issue, the bracket logic is in #7399

@iSazonov
Copy link
Collaborator

Please continue discussion in #12168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change breaking change that may affect users Review - Committee The PR/Issue needs a review from the PowerShell Committee

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants