-
Notifications
You must be signed in to change notification settings - Fork 8.1k
"Path is not parsed correctly if '[' is present in the path" #12170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Mar 21, 2020
Collaborator
rjmholt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should add tests for examples where behaviour has changed.
Also we should consider it with respect to the discussion and work done in #7399
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
Contributor
Collaborator
|
Please continue discussion in #12168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking-Change
breaking change that may affect users
Review - Committee
The PR/Issue needs a review from the PowerShell Committee
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
This PR helps to fix this issue that I raised. Path is not parsed correctly if '[' is present in the path #12168
Issues fixed:
Having '[' character in directory doesn't work.
Create a directory: e:[test
Repro 1:
Test-Path 'e:[test'
Output: Error
Expected Output: True
Repro 2:
Test-Path "e:`[test"
Output: Error
Expected Output: True
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.