Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Mar 20, 2020

PR Summary

Put symbols is separate zip package

PR Context

We only have one manifest for the x86 and x64 msi. So the package content cannot vary

PR Checklist

@TravisEz13 TravisEz13 changed the title Don't put symbols in msi Put symbols in separate package Mar 21, 2020
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 21, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Mar 21, 2020
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minor comment: mandatory parameter doesn’t need the nullorempty validation.

@TravisEz13 TravisEz13 merged commit 7a8094f into PowerShell:master Mar 21, 2020
@TravisEz13 TravisEz13 deleted the don't_put_symbols_in_MSI branch March 21, 2020 19:36
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants