Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Mar 17, 2020

PR Summary

Updated associated build files to netcoreapp5.0 and ref assemblies to 5.0-preview.1 where applicable. Updated files.wxs to changes.

PR Checklist

@SteveL-MSFT
Copy link
Member Author

It looks like there's an issue in .NET 5 preview1 where we set the main thread name and that somehow gets propagated as the process name on Linux (only) and so tests that check if it's pwsh ends up failing. I'll see about putting in some reasonable workarounds for now and add a pending test to verify the process name.

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the changes so far

@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Mar 17, 2020
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 17, 2020
@SteveL-MSFT
Copy link
Member Author

.NET 5 specifically has improvements to regex, so needed to increase the size of the DOS test

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Mar 18, 2020

On Windows, pwsh is crashing in a native API call. Opened dotnet/runtime#33703

@danmoseley
Copy link

.NET 5 specifically has improvements to regex, so needed to increase the size of the DOS test

cc @stephentoub 👏

@danmoseley
Copy link

It looks like there's an issue in .NET 5 preview1 where we set the main thread name and that somehow gets propagated as the process name on Linux (only)

@SteveL-MSFT is that a bug in .NET?

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Mar 18, 2020

@danmosemsft The main thread name becoming the process name is a bug in .NET and is understood (dotnet/runtime#33673). That issue isn't blocking as it's currently only affecting tests and I made changes to work around it. The crashing issue (dotnet/runtime#33703) is preventing us from moving to .NET 5. Thanks!

@TravisEz13
Copy link
Member

There is already an issues filed for regex DOS tests: #12138

Remove assembly from startup validation
@SteveL-MSFT
Copy link
Member Author

@PoshChan retry macos

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, successfully started retry of PowerShell-CI-macOS

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 19, 2020
@TravisEz13
Copy link
Member

.NET originally said that the perf improvement was due to optimization, but it's actually due to a bug. I filed an issue to add it back to avoid delaying this PR.
#12155

@stephentoub
Copy link
Contributor

.NET originally said that the perf improvement was due to optimization, but it's actually due to a bug

It's half and half :) The algorithmic complexity improved, in part due to perf improvements, and in part due to a bug fixed in Preview 2 (dotnet/runtime#33409).

@TravisEz13 TravisEz13 changed the title Move to .NET 5 preview.1 Move to .NET 5 preview.1 Mar 19, 2020
@TravisEz13 TravisEz13 merged commit 495dea0 into PowerShell:master Mar 19, 2020
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants