Skip to content

Encoding Parameter for Tee-Object #12135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 6 commits into from
Jul 22, 2021
Merged

Encoding Parameter for Tee-Object #12135

iSazonov merged 6 commits into from
Jul 22, 2021

Conversation

@Peter-Schneider
Copy link
Contributor

@Peter-Schneider Peter-Schneider commented Mar 16, 2020 •
edited
Loading

PR Summary

Adds an Encoding parameter to the Tee-Object cmdlet (See issue #11104)

PR Context

PR Checklist

@ghost ghost assigned iSazonov Mar 16, 2020
vexx32
vexx32 suggested changes Mar 16, 2020
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@vexx32
Copy link
Collaborator

vexx32 commented Mar 16, 2020

Ha, you beat me to it. 😁

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
christian7877
christian7877 suggested changes Mar 16, 2020
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@Peter-Schneider
Copy link
Contributor Author

Peter-Schneider commented Mar 17, 2020 •
edited
Loading

@vexx32 Thank you anyway.. ;-)

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 17, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Mar 17, 2020

@Peter-Schneider Please add tests.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 17, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Mar 17, 2020
@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Mar 17, 2020
iSazonov
iSazonov reviewed Mar 18, 2020
View reviewed changes
@iSazonov
Copy link
Collaborator

iSazonov commented Mar 20, 2020

@Peter-Schneider Please open new issue in PowerShell-Docs repo for the new parameter and add reference in the PR description.

@Peter-Schneider Peter-Schneider mentioned this pull request Mar 20, 2020
Closed
11 tasks
@iSazonov
Copy link
Collaborator

iSazonov commented Mar 20, 2020

@SteveL-MSFT @TravisEz13 Could you please look CI failures? It seems it is not the PR related.

@TravisEz13
Copy link
Member

TravisEz13 commented Mar 20, 2020

@iSazonov The windows failure definitely seem related to this branch. Perhaps a rebase is needed.

@iSazonov
Copy link
Collaborator

iSazonov commented Mar 20, 2020 •
edited
Loading

@Peter-Schneider Please rebase. You will be switched to new .Net version - 5.0 Preview1, so you should install it.

iSazonov
iSazonov reviewed Mar 21, 2020
View reviewed changes
iSazonov
iSazonov reviewed Mar 21, 2020
View reviewed changes
Peter-Schneider and others added 2 commits March 21, 2020 17:14
@Peter-Schneider
Delte testfile in BeforeEach Pester block
b08faa4
@Peter-Schneider @iSazonov
Fix CI
3af62f4 
Co-Authored-By: Ilya <darpa@yandex.ru>
@TravisEz13 TravisEz13 removed the Review - Needed The PR is being reviewed label Jun 2, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Jun 11, 2020

@TravisEz13 @SteveL-MSFT Could you please review the PR.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 11, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 18, 2020
@ghost
Copy link

ghost commented Jun 18, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan removed this from the 7.1.0-preview.4 milestone Jun 29, 2020
@iSazonov iSazonov closed this Jul 22, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 22, 2020
@iSazonov iSazonov reopened this Jul 22, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 22, 2020

Reopen to update CIs.

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020
@ghost
Copy link

ghost commented Jul 30, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 9, 2021

@SteveL-MSFT Can we merge?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021
@ghost
Copy link

ghost commented Jan 16, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Jul 21, 2021

@iSazonov I think this is good to go. thanks.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 21, 2021
@SteveL-MSFT SteveL-MSFT reopened this Jul 21, 2021
@iSazonov iSazonov merged commit de5dc63 into PowerShell:master Jul 22, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 22, 2021
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 22, 2021

@Peter-Schneider Thanks for your contribution!

@Peter-Schneider
Copy link
Contributor Author

Peter-Schneider commented Jul 22, 2021

Thanks for merging! 🥳

@ghost
Copy link

ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@christian7877 christian7877 christian7877 requested changes

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

7 participants

@Peter-Schneider @vexx32 @iSazonov @TravisEz13 @SteveL-MSFT @christian7877 @adityapatwardhan