Skip to content

Encoding Parameter for Tee-Object - #12135

Merged
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
Peter-Schneider:TeeObjectEncodingParameter
Jul 22, 2021
Merged

Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
Peter-Schneider:TeeObjectEncodingParameter

Conversation

@Peter-Schneider

@Peter-Schneider Peter Schneider (Peter-Schneider) commented Mar 16, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

Adds an Encoding parameter to the Tee-Object cmdlet (See issue #11104)

PR Context

PR Checklist

@ghost ghost assigned Ilya (iSazonov) Mar 16, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@vexx32

Copy link
Copy Markdown
Collaborator

Ha, you beat me to it. 😁

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@Peter-Schneider

Peter Schneider (Peter-Schneider) commented Mar 17, 2020 •

Copy link
Copy Markdown
Contributor Author

Rain Sallow (/u/ta11ow) (@vexx32) Thank you anyway.. ;-)

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 17, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Please add tests.

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 17, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Mar 17, 2020
@iSazonov Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Mar 17, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Please open new issue in PowerShell-Docs repo for the new parameter and add reference in the PR description.

@iSazonov

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Travis Plunk (@TravisEz13) Could you please look CI failures? It seems it is not the PR related.

@TravisEz13

Copy link
Copy Markdown
Member

Ilya (@iSazonov) The windows failure definitely seem related to this branch. Perhaps a rebase is needed.

@iSazonov

Ilya (iSazonov) commented Mar 20, 2020 •

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Please rebase. You will be switched to new .Net version - 5.0 Preview1, so you should install it.

@TravisEz13 Travis Plunk (TravisEz13) removed the Review - Needed The PR is being reviewed label Jun 2, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 10, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Steve Lee (@SteveL-MSFT) Could you please review the PR.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 11, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 18, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 22, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Reopen to update CIs.

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Can we merge?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@SteveL-MSFT

Copy link
Copy Markdown
Member

Ilya (@iSazonov) I think this is good to go. thanks.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 21, 2021
@iSazonov
Ilya (iSazonov) merged commit de5dc63 into PowerShell:master Jul 22, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.8 milestone Jul 22, 2021
@iSazonov

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Thanks for your contribution!

@Peter-Schneider

Copy link
Copy Markdown
Contributor Author

Thanks for merging! 🥳

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants