Skip to content

Implement ForEach-Object -Parallel runspace reuse #12122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 7 commits into from
Mar 23, 2020
Merged

Implement ForEach-Object -Parallel runspace reuse #12122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19daa56
Implement foreach parallel runspace reuse
PaulHigin Mar 12, 2020
0b30889
Change runspace dispose
PaulHigin Mar 13, 2020
0267869
Refactor runspace reset check
PaulHigin Mar 13, 2020
87e2050
Fix race condition.
PaulHigin Mar 13, 2020
bb14550
Fix CodFactor issues
PaulHigin Mar 13, 2020
384314a
Implement -UseNewRunspace parameter switch, add tests
PaulHigin Mar 19, 2020
7083a7c
Fix Codacy error
PaulHigin Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/System.Management.Automation/engine/InternalCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,14 @@ public object[] ArgumentList
[Parameter(ParameterSetName = ForEachObjectCommand.ParallelParameterSet)]
public SwitchParameter AsJob { get; set; }

/// <summary>
/// Gets or sets a flag so that a new runspace object is created for each loop iteration, instead of reusing objects
/// from the runspace pool.
/// By default, runspaces are reused from a runspace pool.
/// </summary>
[Parameter(ParameterSetName = ForEachObjectCommand.ParallelParameterSet)]
public SwitchParameter UseNewRunspace { get; set; }

#endregion

#region Overrides
Expand Down Expand Up @@ -437,15 +445,16 @@ private void InitParallelParameterSet()

_taskJob = new PSTaskJob(
Parallel.ToString(),
ThrottleLimit);
ThrottleLimit,
UseNewRunspace);

return;
}

// Set up for synchronous processing and data streaming.
_taskCollection = new PSDataCollection<System.Management.Automation.PSTasks.PSTask>();
_taskDataStreamWriter = new PSTaskDataStreamWriter(this);
_taskPool = new PSTaskPool(ThrottleLimit);
_taskPool = new PSTaskPool(ThrottleLimit, UseNewRunspace);
_taskPool.PoolComplete += (sender, args) =>
{
_taskDataStreamWriter.Close();
Expand Down
Loading