Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Mar 4, 2020

PR Summary

The change in #11746 conflicted with #11952 resulted in incorrect splitting of the PositionMessage in the ErrorRecord showing the old NormalView line information. Since we are retaining #11746, need to fix the formatting to use [Environment]::NewLine

PR Context

PR Checklist

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 4, 2020
@daxian-dbw
Copy link
Member

@PoshChan please retry static

@PoshChan
Copy link
Collaborator

PoshChan commented Mar 4, 2020

@daxian-dbw, successfully started retry of PowerShell-CI-static-analysis

@daxian-dbw
Copy link
Member

https://shell.azure.com/ should be back already, not sure why it's failing.

For the preview.md issue reported in the static CI, it's caused by moving preview.md to 7.0.0.md in this commit. @adityapatwardhan can you please fix it?

@daxian-dbw
Copy link
Member

I will merge this PR as it has nothing to do with the failures in the static analysis CI.

@daxian-dbw daxian-dbw merged commit 348ca85 into PowerShell:master Mar 4, 2020
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 modified the milestones: 7.0.1-approved, 7.0.1 Apr 20, 2020
@SteveL-MSFT SteveL-MSFT deleted the conciseview-newline branch June 6, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants