Publish PowerShell vPack for stable and better builds
#11960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
# Conflicts: # tools/releaseBuild/setReleaseTag.ps1
TravisEz13
force-pushed
the
publish_vpack
branch
from
5c979f1 to
899b69d
Compare
SteveL-MSFT
reviewed
Feb 26, 2020
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
Member
Author
|
Code is ready for review now. |
TravisEz13
commented
Feb 26, 2020
| value: 1 | ||
| - name: POWERSHELL_TELEMETRY_OPTOUT | ||
| value: 1 | ||
| - group: Azure Blob variable group |
Member
Author
There was a problem hiding this comment.
@adityapatwardhan Note that this YAML tells what variable groups it needs
adityapatwardhan
approved these changes
Feb 26, 2020
| displayName: 'Validate Zip and MSI Package Names' | ||
|
|
||
| - pwsh: | | ||
| $message = @() |
Member
There was a problem hiding this comment.
seems $message is not used
| displayName: Set Build Name for Non-PR | ||
| condition: ne(variables['Build.Reason'], 'PullRequest') | ||
|
|
||
| - template: ./templates/vpackReleaseJob.yml |
Member
There was a problem hiding this comment.
Should we consider:
- Adding approvals?
- Execute only on build.reason manual?
Member
Author
There was a problem hiding this comment.
I did number 2
Let's leave 1 for when we integrate this into a deployment yaml.
TravisEz13
commented
Feb 26, 2020
TravisEz13
commented
Feb 26, 2020
TravisEz13
changed the title
vPack for stable and better builds
TravisEz13
added
the
CL-BuildPackaging
|
🎉 Handy links: |
silijon
pushed a commit
to SkyKick/PowerShell
that referenced
this pull request
Jul 2, 2020
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Publish PowerShell vPack for stable and better builds
PR Context
This is related to windows engineering
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.