Skip to content

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Feb 26, 2020

Fixes #11314

PR Summary

Global tool shim layer should not handle Ctlr+C as it does compete with the launched global tool and makes the usage of console impossible.

PR Context

PR Checklist

@adityapatwardhan adityapatwardhan added this to the GA-consider milestone Feb 26, 2020
@ghost ghost assigned TravisEz13 Feb 26, 2020
@daxian-dbw
Copy link
Member

@adityapatwardhan A question: pwsh can still receive Ctrl+C after adding this handler in the shim layer, right?

@adityapatwardhan
Copy link
Member Author

@daxian-dbw Yes, pwsh still receives the ctlr+c

@adityapatwardhan adityapatwardhan changed the title Disable handling Ctlr C in the global tool shim Enable Ctrl+C to work for global tool Feb 26, 2020
@TravisEz13 TravisEz13 merged commit 4e89698 into PowerShell:master Feb 26, 2020
@DHowett-MSFT
Copy link

Thanks!

@adityapatwardhan adityapatwardhan modified the milestones: GA-approved, 7.0.0 Feb 27, 2020
@adityapatwardhan adityapatwardhan added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 3, 2020
@ghost
Copy link

ghost commented Mar 4, 2020

🎉v7.0.0 has been released which incorporates this pull request.:tada:

Handy links:

@brandedoutcast
Copy link

Dropping this here to let people know this might've also fixed microsoft/vscode#86459 & microsoft/terminal#1894

@adityapatwardhan adityapatwardhan deleted the FixGblTool branch June 8, 2020 18:24
silijon pushed a commit to SkyKick/PowerShell that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pwsh as a dotnet global tool exhibits very unusual behavior with Ctrl-C

5 participants