Catch IOException in Get-FileHash #11944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
added
the
CL-General
mklement0
reviewed
Feb 24, 2020
Contributor
There was a problem hiding this comment.
This should be WriteError() too - as in the original WinPS implementation, any exception for a given pipeline input should be a non-terminating error.
Collaborator
Author
There was a problem hiding this comment.
Yes, It is was copy-past without fix.
iSazonov
force-pushed
the
catch-ioexc-getfilehash
branch
from
ef07923 to
9fa6d77
Compare
daxian-dbw
reviewed
Mar 13, 2020
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
@iSazonov You can use the special .sys file on the system drive of a windows OS for the test, for example, pagefile.sys or swapfile.sys.
Collaborator
Author
|
@daxian-dbw I added new test. |
PoshChan
reviewed
Mar 13, 2020
PoshChan
reviewed
Mar 13, 2020
PoshChan
reviewed
Mar 13, 2020
PoshChan
reviewed
Mar 13, 2020
PoshChan
reviewed
Mar 13, 2020
Collaborator
Author
|
Oh, It turns out CI Windows VM redirect pagefile.sys so I have to use WMI to find it in the new test. |
Member
|
Didn't know you can use cim cmdlet for that, very cool :) |
daxian-dbw
approved these changes
Mar 13, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #11931
Catch all IO exceptions in Get-FileHash cmdlet to do not terminate pipeline.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.