Skip to content

Conversation

@PaulHigin
Copy link
Contributor

PR Summary

This PR fixes a regression introduced with PR #11518.

PR Context

As part of the 11518 PR feedback, the author was asked to use .Net StartInfo.ArgumentList rather than the Arguments property. But the Windows and Linux platforms use different code paths for actually creating the ssh process, and the Windows platform code path was not updated to use the ArgumentList property.

Fix is to use ArgumentList property.

PR Checklist

@daxian-dbw
Copy link
Member

@PoshChan Please retry windows

@PoshChan
Copy link
Collaborator

@daxian-dbw, successfully started retry of PowerShell-CI-Windows

@TravisEz13 TravisEz13 changed the title [Regression] Fix SSH remoting error on Windows platform Fix SSH remoting error on Windows platform Feb 20, 2020
@TravisEz13 TravisEz13 added this to the GA-approved milestone Feb 20, 2020
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 20, 2020
@TravisEz13 TravisEz13 merged commit d3ad083 into PowerShell:master Feb 20, 2020
@TravisEz13 TravisEz13 modified the milestones: GA-approved, 7.0.0-rc.3 Feb 20, 2020
@PaulHigin PaulHigin deleted the fix-ssh-regression branch February 21, 2020 15:50
@ghost
Copy link

ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants