Skip to content

Make LTS package always not a preview #11895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 2 commits into from
Feb 19, 2020
Merged

Make LTS package always not a preview #11895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec80f17
Make LTS package always not a preview
daxian-dbw Feb 19, 2020
0109b74
Address Travis's comment
daxian-dbw Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,16 @@ function Test-IsPreview
param(
[parameter(Mandatory)]
[string]
$Version
$Version,

[switch]$IsLTS
)

if ($IsLTS.IsPresent) {
## If we are building a LTS package, then never consider it preview.
return $false
}

return $Version -like '*-*'
}

Expand Down
4 changes: 2 additions & 2 deletions tools/packaging/packaging.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ function New-UnixPackage {
}

# Determine if the version is a preview version
$IsPreview = Test-IsPreview -Version $Version
$IsPreview = Test-IsPreview -Version $Version -IsLTS:$LTS

# Preview versions have preview in the name
$Name = if($LTS) {
Expand Down Expand Up @@ -1452,7 +1452,7 @@ function New-MacOSLauncher
[switch]$LTS
)

$IsPreview = Test-IsPreview -Version $Version
$IsPreview = Test-IsPreview -Version $Version -IsLTS:$LTS
$packageId = Get-MacOSPackageId -IsPreview:$IsPreview

# Define folder for launcher application.
Expand Down