Skip to content

Use span-based overloads #11884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Mar 18, 2020
Merged

Use span-based overloads #11884

iSazonov merged 3 commits into from
Mar 18, 2020

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Feb 19, 2020 •
edited
Loading

PR Summary

  • First commit - Use span-based overloads to reduce allocations.
  • Second commit - Use String.Contains() for readability.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Feb 19, 2020
@iSazonov iSazonov requested a review from SteveL-MSFT February 19, 2020 11:07
SteveL-MSFT
SteveL-MSFT reviewed Feb 19, 2020
View reviewed changes
src/System.Management.Automation/engine/ParameterBinderController.cs Outdated
Copy link
Member

@SteveL-MSFT SteveL-MSFT Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToString() here results in an allocation, can we just update that method to accept a readonlyspan?

Copy link
Collaborator Author

@iSazonov iSazonov Feb 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is used then in class ctor-s.

Copy link
Collaborator

@vexx32 vexx32 Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReadOnlySpan<char> typically is an implicit cast from string, isn't it?

Copy link
Collaborator Author

@iSazonov iSazonov Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vexx32 No, only string -> ReadOnlySpan

Copy link
Collaborator

@vexx32 vexx32 Feb 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, so if the method parameter is currently using string we should be able to change it to ReadOnlySpan<char> and have the implicit cast handle it, shouldn't we? Or am I missing some context here? 🙂

Copy link
Collaborator Author

@iSazonov iSazonov Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missing some context here

CreateParameterWithArgument() passes the string to a constructor so it makes no sense to convert to span here.

@iSazonov
Copy link
Collaborator Author

iSazonov commented Feb 20, 2020

Added new commit.

@iSazonov iSazonov force-pushed the cleanup-use-span-overloads branch from 2627a51 to 372c510 Compare February 20, 2020 09:16
@iSazonov iSazonov force-pushed the cleanup-use-span-overloads branch from 372c510 to 3e3fad1 Compare March 9, 2020 17:31
SteveL-MSFT
SteveL-MSFT approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daxian-dbw
daxian-dbw reviewed Mar 13, 2020
View reviewed changes
src/Microsoft.Management.UI.Internal/ShowCommand/ViewModel/ModuleViewModel.cs Outdated
Copy link
Member

@daxian-dbw daxian-dbw Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use multiple statements for better readability, like

var filterSpan = filter.AsSpan(0, filter.Length - 2);
return commandName.AsSpan().Contains(filterSpan, StringComparison.OrdinalIgnoreCase);

Copy link
Collaborator Author

@iSazonov iSazonov Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

daxian-dbw
daxian-dbw reviewed Mar 13, 2020
View reviewed changes
src/Microsoft.Management.UI.Internal/ShowCommand/ViewModel/ModuleViewModel.cs Outdated
Copy link
Member

@daxian-dbw daxian-dbw Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here :)

Copy link
Collaborator Author

@iSazonov iSazonov Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@iSazonov iSazonov force-pushed the cleanup-use-span-overloads branch from 3e3fad1 to 5d7aeed Compare March 13, 2020 06:57
@iSazonov iSazonov merged commit b5d4739 into PowerShell:master Mar 18, 2020
@iSazonov iSazonov deleted the cleanup-use-span-overloads branch March 18, 2020 13:39
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@iSazonov iSazonov mentioned this pull request Oct 29, 2020
Merged
14 tasks
@iSazonov iSazonov mentioned this pull request Jan 3, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

+2 more reviewers

@vexx32 vexx32 vexx32 left review comments

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

6 participants

@iSazonov @daxian-dbw @SteveL-MSFT @vexx32 @PoshChan @adityapatwardhan