Update LTS logic to depend on metadata.json #11877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
TravisEz13,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
PoshChan
reviewed
Feb 18, 2020
| $Arguments = @{ | ||
| PackageSourcePath = $Source | ||
| Name = $Name | ||
| PackageNameSuffix = 'fxdependent' |
Collaborator
There was a problem hiding this comment.
@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-macos
Verify sub-directory creation under root.Can create a sub directory under root path
Expected path '\TestDir-e4930d6c-2f03-4823-8c9c-c999fdef9dfa' to exist, but it did not exist.
at <ScriptBlock>, /Users/runner/runners/2.164.8/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 1467
1467: $dirPath | Should -Exist
TravisEz13
approved these changes
Feb 18, 2020
Member
Author
|
@PoshChan please rebuild all |
Collaborator
|
@adityapatwardhan, successfully started rebuild of |
adityapatwardhan
added
the
CL-BuildPackaging
|
🎉 Handy links: |
silijon
pushed a commit
to SkyKick/PowerShell
that referenced
this pull request
Jul 2, 2020
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the LTS logic to be dependent on metadata.json and do not build LTS packages for tar.gz
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.