Refactor packaging pipeline #11852
Refactor packaging pipeline #11852
Conversation
adityapatwardhan
requested review from
anmenaga and
daxian-dbw
as code owners
ghost
assigned
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
@adityapatwardhan Thanks for the super fast turnaround!
| parentJob: '' | ||
|
|
||
| jobs: | ||
| - job: sign_windows_${{ parameters.Architecture }} |
There was a problem hiding this comment.
This template is for generating packages with signed files, so maybe named it package_windows_$...?
There was a problem hiding this comment.
Changes like this can have ripple effects which are hard to identify... let's file an issue and move one.
| Architecture: arm64 | ||
| parentJob: build_windows_arm64 | ||
|
|
||
| - template: templates/windows-component-governance.yml |
There was a problem hiding this comment.
Is this replaced by
task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
from the windows hosted build.yml?
| - sign_windows_arm | ||
| - sign_windows_arm64 | ||
| - sign_windows_fxdependent | ||
| - sign_windows_fxdependentWinDesktop |
There was a problem hiding this comment.
It's a little confusing seeing the package_signing.yml depend on sign_windows_xx jobs, so I think it's probably better to rename the job in windows-packaging.yml.
| } | ||
| $toolsDir = New-Item -ItemType Directory -Path '$(Build.ArtifactStagingDirectory)\tools' | ||
| $wixUri = 'https://github.com/wixtoolset/wix3/releases/download/wix311rtm/wix311-binaries.zip' |
There was a problem hiding this comment.
we should file an issue that these should be in our storage
Co-Authored-By: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
adityapatwardhan
added
the
CL-BuildPackaging
|
🎉 Handy links: |
|
🎉 Handy links: |
4 participants
PR Summary
Refactor package build to remove the dependency on Docker for building Windows packages.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.