Make sure LTS packages have symlink for pwsh and pwsh-lts
#11843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
adityapatwardhan
approved these changes
Feb 13, 2020
adityapatwardhan
added
the
CL-BuildPackaging
daxian-dbw
reviewed
Feb 13, 2020
PoshChan
reviewed
Feb 13, 2020
daxian-dbw
force-pushed
the
fix_lts_packages
branch
from
7cc67fa to
349f8c5
Compare
PoshChan
reviewed
Feb 14, 2020
| function Invoke-CIFinish | ||
| { | ||
| param( | ||
| [string] $NuGetKey |
Collaborator
There was a problem hiding this comment.
@daxian-dbw, your last commit had 1 failures in PowerShell-CI-linux
Invoke-WebRequest tests.Denial of service.Charset Parsing
Expected the actual value to be greater than 5, but got 0.32999946773053.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1: line 1961
1961: $pathologicalRatio | Should -BeGreaterThan 5
TravisEz13
changed the title
LTS packages have symlink for pwsh and pwsh-lts
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Feb 18, 2020
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Make sure LTS packages have symlink for pwsh and pwsh-lts
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.