Skip to content

Unsealed IDisposable should contain protected virtual void Dispose(bool) method #11820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xtqqczze wants to merge 7 commits into from
Closed

Unsealed IDisposable should contain protected virtual void Dispose(bool) method #11820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b302fea
Fix IDisposable implementation by defining Dispose method as virtual
xtqqczze Feb 10, 2020
6313896
Define Dispose as protected virtual instead of private in unsealed cl…
xtqqczze Feb 10, 2020
34b7535
Revert changes to non-public classes
xtqqczze Apr 10, 2020
f56f9ec
revert addition of `virtual`
xtqqczze Jul 9, 2020
3ef7097
Seal classes not meant to be derived from
xtqqczze Jul 9, 2020
4f94c51
Merge branch 'master' into patch-dispose-virtual-method
xtqqczze Dec 29, 2024
39a233c
revert addition of virtual
xtqqczze Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/hostifaces/PSDataCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,7 @@ public void Dispose()
/// Release all the resources.
/// </summary>
/// <param name="disposing">If true, release all managed resources.</param>
protected void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/ConnectPSSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ public void Dispose()
/// </summary>
/// <param name="disposing">Whether method is called
/// from Dispose or destructor</param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/DisconnectPSSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ public void Dispose()
/// </summary>
/// <param name="disposing">Whether method is called
/// from Dispose or destructor</param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2069,7 +2069,7 @@ public void Dispose()
/// Internal dispose method which does the actual disposing.
/// </summary>
/// <param name="disposing">Whether called from dispose or finalize.</param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/ReceiveJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ public void Dispose()
/// <summary>
/// </summary>
/// <param name="disposing"></param>
protected void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/RemoveJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ public void Dispose()
/// <summary>
/// </summary>
/// <param name="disposing"></param>
protected void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (!disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/StartJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,7 @@ public void Dispose()
/// Internal dispose method which does the actual disposing.
/// </summary>
/// <param name="disposing">Whether called from dispose or finalize.</param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/StopJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public void Dispose()
/// <summary>
/// </summary>
/// <param name="disposing"></param>
protected void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (!disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/commands/WaitJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ public void Dispose()
/// <param name="disposing">
/// if true, release all the managed objects.
/// </param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/common/throttlemanager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ public void Dispose()
/// </summary>
/// <param name="disposing">If method is called from
/// disposing of destructor</param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/fanin/WSManNativeAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ public void Dispose()
GC.SuppressFinalize(this);
}

private void Dispose(bool isDisposing)
protected virtual void Dispose(bool isDisposing)
{
// Managed objects should not be deleted when this is called via the finalizer
// because they may have been collected already. To prevent leaking the marshalledBuffer
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/runtime/Operations/MiscOps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,7 @@ public void Dispose()
GC.SuppressFinalize(this);
}

private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (_disposed)
return;
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/utils/PlatformInvokes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ public void Dispose()
/// Dispose.
/// </summary>
/// <param name="disposing"></param>
private void Dispose(bool disposing)
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
Expand Down