Skip to content

Conversation

@anmenaga
Copy link

@anmenaga anmenaga commented Feb 7, 2020

PR Summary

WinCompat uses background Windows PS remote session which has its own current directory. It has to be synchronized with local PS Core current directory for cases when proxy cmdlets rely on current directory.
This PR enables auto-sync of current directory in WinCompat remote session.

This came up in #11411 .

PR Checklist

@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 7, 2020
@SteveL-MSFT SteveL-MSFT added this to the GA-consider milestone Feb 10, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
# after WinCompat cleanup local $PWD changes should not cause errors
Remove-module $ModuleName -Force
Pop-Location
try
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think all code after the first 'Push-Location' should be in the try. If any exception is thrown during the test the original location will be reverted through the finally 'Set-Location'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan merged commit d2cb3c3 into PowerShell:master Feb 11, 2020
@TravisEz13 TravisEz13 modified the milestones: GA-consider, GA-approved, 7.0.0 Feb 11, 2020
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
# Conflicts:
#	src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
@ghost
Copy link

ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants