Skip to content

Conversation

@JamesWTruher
Copy link
Collaborator

Since the CustomEvent is sent only on startup, we need a way to send
the startup event in those cases where PowerShell is being hosted
(not the console). This will check to see if we have already sent the
custom event for startup and send if it hasn't. This will enable us
to track some of the hosted scenarios like Jupyter.

PR Summary

PR Context

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 7, 2020
Since the CustomEvent is sent only on startup, we need a way to send
the startup event in those cases where PowerShell is being hosted
(not the console). This will check to see if we have already sent the
custom event for startup and send if it hasn't. This will enable us
to track some of the hosted scenarios like Jupyter.
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 8, 2020
@TravisEz13
Copy link
Member

@JamesWTruher I'm going to address the comments because your are OOF and we need this for GA.

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 11, 2020
Copy link
Collaborator Author

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TravisEz13 TravisEz13 changed the title Handle cases where CustomEvent was not initially sent Handle cases where CustomEvent was not initially sent Feb 11, 2020
@TravisEz13 TravisEz13 merged commit 4a0eda7 into PowerShell:master Feb 11, 2020
@TravisEz13 TravisEz13 modified the milestones: GA-consider, GA-approved Feb 11, 2020
@TravisEz13 TravisEz13 added this to the 7.0.0 milestone Feb 11, 2020
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
@ghost
Copy link

ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants