-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Handle cases where CustomEvent was not initially sent
#11807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TravisEz13
merged 3 commits into
PowerShell:master
from
JamesWTruher:telemetryStartupFix
Feb 11, 2020
Merged
Handle cases where CustomEvent was not initially sent
#11807
TravisEz13
merged 3 commits into
PowerShell:master
from
JamesWTruher:telemetryStartupFix
Feb 11, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
approved these changes
Feb 7, 2020
SteveL-MSFT
requested changes
Feb 7, 2020
PoshChan
reviewed
Feb 7, 2020
PoshChan
reviewed
Feb 7, 2020
PoshChan
reviewed
Feb 7, 2020
SteveL-MSFT
approved these changes
Feb 7, 2020
Since the CustomEvent is sent only on startup, we need a way to send the startup event in those cases where PowerShell is being hosted (not the console). This will check to see if we have already sent the custom event for startup and send if it hasn't. This will enable us to track some of the hosted scenarios like Jupyter.
a1ae7e9 to
ec607c5
Compare
Member
|
@JamesWTruher I'm going to address the comments because your are OOF and we need this for GA. |
d47177f to
7d3a0eb
Compare
daxian-dbw
approved these changes
Feb 11, 2020
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@TravisEz13, this is the reminder you requested 1 hour ago |
JamesWTruher
commented
Feb 11, 2020
Collaborator
Author
JamesWTruher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CustomEvent was not initially sent
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Feb 18, 2020
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the CustomEvent is sent only on startup, we need a way to send
the startup event in those cases where PowerShell is being hosted
(not the console). This will check to see if we have already sent the
custom event for startup and send if it hasn't. This will enable us
to track some of the hosted scenarios like Jupyter.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.