Skip to content

Fix NRE in ActionPreference parameters #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iSazonov wants to merge 1 commit into from
Closed

Fix NRE in ActionPreference parameters #11779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/System.Management.Automation/engine/CommonCommandParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public SwitchParameter Debug
/// This parameter tells the command what to do when an error occurs.
/// </remarks>
[Parameter]
[ValidateNotNull]
[Alias("ea")]
public ActionPreference ErrorAction
{
Expand All @@ -94,6 +95,7 @@ public ActionPreference ErrorAction
/// occurs.
/// </remarks>
[Parameter]
[ValidateNotNull]
[Alias("wa")]
public ActionPreference WarningAction
{
Expand All @@ -115,6 +117,7 @@ public ActionPreference WarningAction
/// was added to PowerShell, so "infa" was chosen instead.
/// -->
[Parameter]
[ValidateNotNull]
[Alias("infa")]
public ActionPreference InformationAction
{
Expand Down
7 changes: 7 additions & 0 deletions test/powershell/Language/Scripting/ActionPreference.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,13 @@ Describe "Tests for (error, warning, etc) action preference" -Tags "CI" {
{ New-Item @params } | Should -Throw -ErrorId "NewItemIOError,Microsoft.PowerShell.Commands.NewItemCommand"
Remove-Item "$testdrive\test.txt" -Force
}

It "Parameter binding throws correctly (no NRE) if argument is null" {
$NullVariable = $null
{ Test-Path .\noexistfile.ps1 -ErrorAction $NullVariable } | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.TestPathCommand"
{ Test-Path .\noexistfile.ps1 -InformationAction $NullVariable } | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.TestPathCommand"
{ Test-Path .\noexistfile.ps1 -WarningAction $NullVariable } | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.TestPathCommand"
}
}

Describe 'ActionPreference.Break tests' -tag 'CI' {
Expand Down