PowerShell · xtqqczze · Feb 5, 2020 · Feb 5, 2020 · Feb 5, 2020 · Feb 5, 2020
diff --git a/...ft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/TerminatingErrorTracker.cs b/...ft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/TerminatingErrorTracker.cs
@@ -19,7 +19,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Tracks (per-session) terminating errors in a given cmdlet invocation.
     /// </summary>
-    internal class TerminatingErrorTracker
+    internal sealed class TerminatingErrorTracker
     {
         #region Getting tracker for a given cmdlet invocation
 

diff --git a/....PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimOperationOptionsHelper.cs b/....PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimOperationOptionsHelper.cs
@@ -14,7 +14,7 @@
 
 namespace Microsoft.PowerShell.Cmdletization.Cim
 {
-    internal class CimCustomOptionsDictionary
+    internal sealed class CimCustomOptionsDictionary
     {
         private readonly IDictionary<string, object> _dict;
         private readonly object _dictModificationLock = new object();

diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/TimeZoneCommands.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/TimeZoneCommands.cs
@@ -428,15 +428,8 @@ protected void ThrowWin32Error()
 
         #region Win32 interop helper
 
-        internal class NativeMethods
+        internal static class NativeMethods
         {
-            /// <summary>
-            /// Private constructor to prevent instantiation.
-            /// </summary>
-            private NativeMethods()
-            {
-            }
-
             #region Native DLL locations
 
             private const string SetDynamicTimeZoneApiDllName = "api-ms-win-core-timezone-l1-1-0.dll";

diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/New-Object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/New-Object.cs
@@ -498,12 +498,8 @@ private object CreateComObject()
     /// <summary>
     /// Native methods for dealing with COM objects.
     /// </summary>
-    internal class NewObjectNativeMethods
+    internal static class NewObjectNativeMethods
     {
-        private NewObjectNativeMethods()
-        {
-        }
-
         /// Return Type: HRESULT->LONG->int
         [DllImport(PinvokeDllNames.CLSIDFromProgIDDllName)]
         internal static extern int CLSIDFromProgID([MarshalAs(UnmanagedType.LPWStr)] string lpszProgID, out Guid pclsid);

diff --git a/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs b/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
@@ -58,7 +58,7 @@ public void Dispose()
             Dispose();
         }
 
-        private class PropVariantNativeMethods
+        private static class PropVariantNativeMethods
         {
             [DllImport("Ole32.dll", PreserveSig = false)]
             internal static extern void PropVariantClear([In, Out] PropVariant pvar);

diff --git a/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/Reader/NativeWrapper.cs b/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/Reader/NativeWrapper.cs
@@ -22,7 +22,7 @@
 
 namespace System.Diagnostics.Eventing.Reader
 {
-    internal class NativeWrapper
+    internal static class NativeWrapper
     {
         public class SystemProperties
         {

diff --git a/src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/StringUtil.cs b/src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/StringUtil.cs
@@ -9,15 +9,8 @@ namespace System.Management.Automation.SecurityAccountsManager
     /// <summary>
     /// Contains utility functions for formatting localizable strings.
     /// </summary>
-    internal class StringUtil
+    internal static class StringUtil
     {
-        /// <summary>
-        /// Private constructor to precent auto-generation of a default constructor with greater accessability.
-        /// </summary>
-        private StringUtil()
-        {
-        }
-
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
         internal static string Format(string str)
         {

diff --git a/src/Microsoft.PowerShell.ScheduledJob/ScheduledJobDefinition.cs b/src/Microsoft.PowerShell.ScheduledJob/ScheduledJobDefinition.cs
@@ -2300,7 +2300,7 @@ internal string FQEID
     /// <summary>
     /// Simple string formatting helper.
     /// </summary>
-    internal class StringUtil
+    internal static class StringUtil
     {
         internal static string Format(string formatSpec, object o)
         {

diff --git a/src/System.Management.Automation/AssemblyInfo.cs b/src/System.Management.Automation/AssemblyInfo.cs
@@ -27,7 +27,7 @@
 
 namespace System.Management.Automation
 {
-    internal class NTVerpVars
+    internal static class NTVerpVars
     {
         internal const int PRODUCTMAJORVERSION = 10;
         internal const int PRODUCTMINORVERSION = 0;

diff --git a/src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs b/src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
@@ -15,7 +15,7 @@ namespace System.Management.Automation
     /// <summary>
     /// The powershell custom AssemblyLoadContext implementation.
     /// </summary>
-    internal partial class PowerShellAssemblyLoadContext
+    internal sealed partial class PowerShellAssemblyLoadContext
     {
         #region Resource_Strings
 

diff --git a/src/System.Management.Automation/FormatAndOutput/common/FormatXMLWriter.cs b/src/System.Management.Automation/FormatAndOutput/common/FormatXMLWriter.cs
@@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.Commands
     /// <summary>
     /// Helper class for writing formatting directives to XML.
     /// </summary>
-    internal class FormatXmlWriter
+    internal sealed class FormatXmlWriter
     {
         private XmlWriter _writer;
         private bool _exportScriptBlock;

diff --git a/src/System.Management.Automation/engine/COM/ComUtil.cs b/src/System.Management.Automation/engine/COM/ComUtil.cs
@@ -16,7 +16,7 @@ namespace System.Management.Automation
     /// <summary>
     /// Defines a utility class that is used by COM adapter.
     /// </summary>
-    internal class ComUtil
+    internal static class ComUtil
     {
         // HResult error code '-2147352573' - Member not found.
         internal const int DISP_E_MEMBERNOTFOUND = unchecked((int)0x80020003);

diff --git a/src/System.Management.Automation/engine/CommandInfo.cs b/src/System.Management.Automation/engine/CommandInfo.cs
@@ -925,7 +925,7 @@ public PSMemberNameAndType(string name, PSTypeName typeName, object value = null
     /// but can be used where a real type might not be available, in which case the name of the type can be used.
     /// The type encodes the members of dynamic objects in the type name.
     /// </summary>
-    internal class PSSyntheticTypeName : PSTypeName
+    internal sealed class PSSyntheticTypeName : PSTypeName
     {
         internal static PSSyntheticTypeName Create(string typename, IList<PSMemberNameAndType> membersTypes) => Create(new PSTypeName(typename), membersTypes);
 

diff --git a/...nagement.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs b/...nagement.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs
@@ -70,7 +70,7 @@ protected override void ProcessRecord()
         }
     }
 
-    internal class ExperimentalFeatureConfigHelper
+    internal static class ExperimentalFeatureConfigHelper
     {
         internal static void UpdateConfig(PSCmdlet cmdlet, string[] name, ConfigScope scope, bool enable)
         {

diff --git a/src/System.Management.Automation/engine/InitialSessionState.cs b/src/System.Management.Automation/engine/InitialSessionState.cs
@@ -26,7 +26,7 @@
 
 namespace System.Management.Automation.Runspaces
 {
-    internal class EarlyStartup
+    internal static class EarlyStartup
     {
         internal static void Init()
         {

diff --git a/src/System.Management.Automation/engine/Modules/AnalysisCache.cs b/src/System.Management.Automation/engine/Modules/AnalysisCache.cs
@@ -27,7 +27,7 @@ namespace System.Management.Automation
     /// Changes to these type of modules will not be re-analyzed, unless the user re-imports the module,
     /// or runs Get-Module -List.
     /// </summary>
-    internal class AnalysisCache
+    internal static class AnalysisCache
     {
         private static AnalysisCacheData s_cacheData = AnalysisCacheData.Get();
 
@@ -642,7 +642,7 @@ private static bool GetModuleEntryFromCache(string modulePath, out DateTime last
         }
     }
 
-    internal class AnalysisCacheData
+    internal sealed class AnalysisCacheData
     {
         private static byte[] GetHeader()
         {

diff --git a/src/System.Management.Automation/engine/MshMemberInfo.cs b/src/System.Management.Automation/engine/MshMemberInfo.cs
@@ -3666,7 +3666,7 @@ public override PSMemberInfo Copy()
     /// <summary>
     /// /// This class is used in PSMemberInfoInternalCollection and ReadOnlyPSMemberInfoCollection.
     /// </summary>
-    internal class MemberMatch
+    internal static class MemberMatch
     {
         internal static WildcardPattern GetNamePattern(string name)
         {

diff --git a/src/System.Management.Automation/engine/MshSnapinQualifiedName.cs b/src/System.Management.Automation/engine/MshSnapinQualifiedName.cs
@@ -10,7 +10,7 @@ namespace System.Management.Automation
     /// <summary>
     /// A class representing a name that is qualified by the PSSnapin name.
     /// </summary>
-    internal class PSSnapinQualifiedName
+    internal sealed class PSSnapinQualifiedName
     {
         private PSSnapinQualifiedName(string[] splitName)
         {

diff --git a/src/System.Management.Automation/engine/WinRT/IInspectable.cs b/src/System.Management.Automation/engine/WinRT/IInspectable.cs
@@ -26,7 +26,7 @@ internal interface IInspectable { }
     /// <summary>
     /// Helper class for WinRT types.
     /// </summary>
-    internal class WinRTHelper
+    internal static class WinRTHelper
     {
         internal static bool IsWinRTType(Type type)
         {

diff --git a/src/System.Management.Automation/engine/interpreter/PowerShellInstructions.cs b/src/System.Management.Automation/engine/interpreter/PowerShellInstructions.cs
@@ -15,7 +15,7 @@
 
 namespace System.Management.Automation.Interpreter
 {
-    internal class UpdatePositionInstruction : Instruction
+    internal sealed class UpdatePositionInstruction : Instruction
     {
         private readonly int _sequencePoint;
         private readonly bool _checkBreakpoints;

@@ -14,7 +14,7 @@
 
 namespace System.Management.Automation.Language
 {
-    internal class TypeDefiner
+    internal static class TypeDefiner
     {
         internal const string DynamicClassAssemblyName = "PowerShell Class Assembly";
         internal const string DynamicClassAssemblyFullNamePrefix = "PowerShell Class Assembly,";

@@ -356,7 +356,7 @@ public object VisitParenExpression(ParenExpressionAst parenExpressionAst)
      * except in the case of handling the unary operator
      * ExecutionContext is provided to ensure we can resolve variables
      */
-    internal class GetSafeValueVisitor : ICustomAstVisitor2
+    internal sealed class GetSafeValueVisitor : ICustomAstVisitor2
     {
         internal enum SafeValueContext
         {

@@ -15,7 +15,7 @@
 
 namespace System.Management.Automation.Language
 {
-    internal class SemanticChecks : AstVisitor2, IAstPostVisitHandler
+    internal sealed class SemanticChecks : AstVisitor2, IAstPostVisitHandler
     {
         private readonly Parser _parser;
 

@@ -274,7 +274,7 @@ public bool IsInMethodScope()
         }
     }
 
-    internal class SymbolResolver : AstVisitor2, IAstPostVisitHandler
+    internal sealed class SymbolResolver : AstVisitor2, IAstPostVisitHandler
     {
         private readonly SymbolResolvePostActionVisitor _symbolResolvePostActionVisitor;
         internal readonly SymbolTable _symbolTable;

@@ -673,7 +673,7 @@ public override int GetHashCode()
         }
     }
 
-    internal class TypeCache
+    internal static class TypeCache
     {
         private class KeyComparer : IEqualityComparer<Tuple<ITypeName, TypeResolutionState>>
         {

@@ -34,7 +34,7 @@ internal VariableAnalysisDetails()
         public List<Ast> AssociatedAsts { get; }
     }
 
-    internal class FindAllVariablesVisitor : AstVisitor
+    internal sealed class FindAllVariablesVisitor : AstVisitor
     {
         private static readonly HashSet<string> s_hashOfPessimizingCmdlets = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
 

@@ -13,7 +13,7 @@ namespace System.Management.Automation.Remoting
     /// <summary>
     /// Executes methods on the client.
     /// </summary>
-    internal class ClientMethodExecutor
+    internal sealed class ClientMethodExecutor
     {
         /// <summary>
         /// Transport manager.

@@ -1855,7 +1855,7 @@ protected override void ProcessRecord()
     /// <summary>
     /// Utility methods for configuration file commands.
     /// </summary>
-    internal class SessionConfigurationUtils
+    internal static class SessionConfigurationUtils
     {
         /// <summary>
         /// This routine builds a fragment of the config file

@@ -13,7 +13,7 @@ namespace System.Management.Automation.Remoting
     /// version on the server. These capabilities will be used in remote debugging sessions to
     /// determine what is supported by the server.
     /// </summary>
-    internal class RemoteDebuggingCapability
+    internal sealed class RemoteDebuggingCapability
     {
         private readonly HashSet<string> _supportedCommands = new HashSet<string>();
 

@@ -24,7 +24,7 @@ namespace System.Management.Automation.Remoting
     /// guarantees that transmitting on the wire will not change the encoded
     /// object's type.
     /// </summary>
-    internal class RemoteHostEncoder
+    internal static class RemoteHostEncoder
     {
         /// <summary>
         /// Is known type.

@@ -171,7 +171,7 @@ internal enum HostDefaultDataId
     /// <summary>
     /// The HostDefaultData class.
     /// </summary>
-    internal class HostDefaultData
+    internal sealed class HostDefaultData
     {
         /// <summary>
         /// Data.

@@ -267,7 +267,7 @@ private static Guid DeserializeGuid(Stream serializedDataStream)
         #endregion
     }
 
-    internal class RemoteDataObject : RemoteDataObject<object>
+    internal sealed class RemoteDataObject : RemoteDataObject<object>
     {
         #region Constructors / Factory
 

@@ -14,7 +14,7 @@ namespace System.Management.Automation
     /// <summary>
     /// Execution context used for stepping.
     /// </summary>
-    internal class ExecutionContextForStepping : IDisposable
+    internal sealed class ExecutionContextForStepping : IDisposable
     {
         private ExecutionContext _executionContext;
         private PSInformationalBuffers _originalInformationalBuffers;
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,7 +70,7 @@ protected override void ProcessRecord() @@
             }
         }
-        internal class ExperimentalFeatureConfigHelper
+        internal static class ExperimentalFeatureConfigHelper
         {
             internal static void UpdateConfig(PSCmdlet cmdlet, string[] name, ConfigScope scope, bool enable)
             {
@@ Expand Down @@