Skip to content

OBSOLETE: Update accessibility modifiers #11773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xtqqczze wants to merge 8 commits into from
Closed

OBSOLETE: Update accessibility modifiers #11773

xtqqczze wants to merge 8 commits into from

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 5, 2020 •
edited
Loading

PR Summary

  • Autofix RCS1102: Make class static when only containing static members.
    • plus 4 manual fixes
  • Autofix RCS1225: Make class sealed when only having a private constructor.
    • Fix CA1047: Do not declare protected members in sealed types
  • Change sealed classes with private constructors to static classes
  • Revert changes to public APIs causing test failures

PR Context

https://github.com/PowerShell/PowerShell/blob/master/docs/dev-process/coding-guidelines.md#member-conventions

PR Checklist

@ghost ghost assigned iSazonov Feb 5, 2020
@vexx32
Copy link
Collaborator

vexx32 commented Feb 5, 2020

@xtqqczze you may want to update the PR description with your reasoning for each change, since most of them seem to be on a per-class basis. I'd also recommend a more general PR title, since it seems you're not only adding static modifiers here, so it's probably a little less confusing to use something like Update class modifiers and explain static / sealed / etc for each class you're changing in the PR description. 🙂

@xtqqczze xtqqczze changed the title WIP: Make classes having only static members static WIP: Change class modifiers to static where applicable Feb 5, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 5, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Feb 5, 2020
iSazonov
iSazonov reviewed Feb 5, 2020
View reviewed changes
src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs Outdated
Copy link
Collaborator

@iSazonov iSazonov Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulHigin @TravisEz13 Can we make the class static?

Copy link
Contributor Author

@xtqqczze xtqqczze Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class contains only static members.

Copy link
Contributor Author

@xtqqczze xtqqczze Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov Should I revert?

@xtqqczze xtqqczze changed the title WIP: Change class modifiers to static where applicable WIP: Update accessibility modifiers Feb 5, 2020
xtqqczze
xtqqczze commented Feb 5, 2020
View reviewed changes
xtqqczze
xtqqczze commented Feb 5, 2020
View reviewed changes
xtqqczze
xtqqczze commented Feb 5, 2020
View reviewed changes
xtqqczze
xtqqczze commented Feb 5, 2020
View reviewed changes
@xtqqczze xtqqczze force-pushed the static-classes branch 2 times, most recently from c7891dd to 0c99e14 Compare February 5, 2020 06:21
iSazonov
iSazonov reviewed Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we set sealed for internal classes? Can you add more info in the PR description?

@ghost ghost added the Review - Needed The PR is being reviewed label May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented May 27, 2020

@xtqqczze Have you plans to continue? Please resolve merge conflicts.

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 25, 2020

Please separate the static and sealed changes.

@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 25, 2020
@xtqqczze xtqqczze marked this pull request as draft October 26, 2020 16:23
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 26, 2020

I will separate changes into new PRs, converting to draft.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 29, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

I will separate changes into new PRs, converting to draft.

Have you any updates?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 5, 2020

I will separate changes into new PRs, converting to draft.

Have you any updates?

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 5, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

I will separate changes into new PRs, converting to draft.

Have you any updates?

So the PR can be closed?

@xtqqczze xtqqczze changed the title Update accessibility modifiers WIP: Update accessibility modifiers Nov 5, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 9, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 21, 2020

I will separate changes into new PRs, converting to draft.

Have you any updates?

So the PR can be closed?

@xtqqczze Can we close?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 23, 2020

@xtqqczze Can we close?

This PR has some changes that depends on #13897, so it should stay as draft.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 23, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 6, 2020

RCS1102 changes are split to #14335.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 6, 2020
@ghost ghost added the Stale label Dec 24, 2020
@ghost
Copy link

ghost commented Dec 24, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jan 4, 2021
@iSazonov iSazonov mentioned this pull request Jun 24, 2021
Closed
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 25, 2021

e0e60ba changes submitted as #15671.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Jun 25, 2021
@xtqqczze xtqqczze deleted the static-classes branch June 25, 2021 14:09
@xtqqczze xtqqczze mentioned this pull request Jun 25, 2021
Merged
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 25, 2021

2069d92 changes submitted as #15675

@xtqqczze xtqqczze changed the title WIP: Update accessibility modifiers OBSOLETE: Update accessibility modifiers Jun 25, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 25, 2021

Changes from this PR are now either merged or submitted in PRs.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience SeeminglyScience will be requested when the pull request is marked ready for review SeeminglyScience is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xtqqczze @vexx32 @iSazonov @daxian-dbw @TravisEz13 @adityapatwardhan