Skip to content

Conversation

@joeltankam
Copy link
Contributor

Fix .NET CLI version

Fix .NET CLI version
@ghost ghost assigned daxian-dbw Jan 29, 2020

We use the [.NET Command Line Interface][dotnet-cli] (`dotnet`) to build PowerShell.
The version we are currently using is `3.0.0`.
The version we are currently using is mentionned in [`global.json`](../../global.json#L3) at the root of this repository.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use absolute path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by absolute path? https://github.com/PowerShell/PowerShell/blob/master/global.json?
I don't think that's a good practice.

@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 31, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 31, 2020
@iSazonov iSazonov self-assigned this Jan 31, 2020
@iSazonov iSazonov changed the title Update Build documentation Add link to .NET CLI version in build documentation Jan 31, 2020
@iSazonov iSazonov merged commit 3d90f5e into PowerShell:master Jan 31, 2020
@iSazonov
Copy link
Collaborator

@joeltankam Thanks for your contribution.

@joeltankam joeltankam deleted the patch-3 branch January 31, 2020 08:57
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants