Skip to content

Change regex to match relation-types w/o quotes in Link header #11711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 5 commits into from
Jan 31, 2020
Merged

Change regex to match relation-types w/o quotes in Link header #11711

TravisEz13 merged 5 commits into from
Jan 31, 2020

Conversation

@Marusyk
Copy link
Contributor

@Marusyk Marusyk commented Jan 28, 2020 •
edited by TravisEz13
Loading

PR Summary

Change regex to match relation-types without quotes in Link header.

PR Context

Fixes #11629

PR Checklist

Please review,
Thank you in advance

@ghost ghost assigned TravisEz13 Jan 28, 2020
@iSazonov iSazonov self-requested a review January 29, 2020 07:34
@TravisEz13 TravisEz13 added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 29, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Jan 29, 2020
TravisEz13
TravisEz13 previously requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests failures and address @iSazonov 's comments

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 29, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 29, 2020
@TravisEz13
Copy link
Member

TravisEz13 commented Jan 30, 2020

It would be good to add a tests to make sure this doesn't regress

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 31, 2020

@TravisEz13 I do not find how we could add the test. We use AspNetCore for test and AspNetCore sends the header as-is.

@TravisEz13
Copy link
Member

TravisEz13 commented Jan 31, 2020

@iSazonov Thanks for the explanation.

@TravisEz13 TravisEz13 dismissed their stale review January 31, 2020 22:06

issues addressed

@TravisEz13 TravisEz13 changed the title Change regex to match relation-types without quotes in Link header Change regex to match relation-types w/o quotes in Link header Jan 31, 2020
@TravisEz13 TravisEz13 merged commit 0eaa41b into PowerShell:master Jan 31, 2020
@Marusyk Marusyk deleted the marusyk/regex branch January 31, 2020 22:44
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 1, 2020

@Marusyk Thanks for your contribution.

@Marusyk
Copy link
Contributor Author

Marusyk commented Feb 1, 2020

Thanks for review and help

@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@TravisEz13 TravisEz13 TravisEz13 left review comments

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

-FollowRelLink does not work if Link header uses rel=next (no quotes) instead of rel="next"

3 participants

@Marusyk @TravisEz13 @iSazonov