Skip to content

Make -OutFile param in web cmdlets to work like -LiteralPath #11701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 6 commits into from
May 20, 2020
Merged

Make -OutFile param in web cmdlets to work like -LiteralPath #11701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68e469a
Replace OutFile parameter with Path and LiteralPath in web cmdlets
iSazonov Jan 28, 2020
8ccf5be
Fix typo in tests
iSazonov Jan 30, 2020
b0bda5a
Revert "Fix typo in tests"
iSazonov Feb 27, 2020
879ed50
Revert "Replace OutFile parameter with Path and LiteralPath in web cm…
iSazonov Feb 27, 2020
ea421db
Address PowerShell Committee conclusion
iSazonov Feb 27, 2020
e0e2d5a
Fix test
iSazonov Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ private Uri CheckProtocol(Uri uri)

private string QualifyFilePath(string path)
{
string resolvedFilePath = PathUtils.ResolveFilePath(path, this, false);
string resolvedFilePath = PathUtils.ResolveFilePath(filePath: path, command: this, isLiteralPath: true);
return resolvedFilePath;
}

Expand Down
5 changes: 3 additions & 2 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@ function ExecuteRequestWithOutFile {
)

$result = [PSObject]@{Output = $null; Error = $null}
$filePath = Join-Path $TestDrive ((Get-Random).ToString() + ".txt")
# We use '[outfile1]' in the file name to check that OutFile parameter is literal path
$filePath = Join-Path $TestDrive ((Get-Random).ToString() + "[outfile1].txt")
try {
if ($cmdletName -eq "Invoke-WebRequest") {
Invoke-WebRequest -Uri $uri -OutFile $filePath
} else {
Invoke-RestMethod -Uri $uri -OutFile $filePath
}
$result.Output = Get-Content $filePath -Raw -ErrorAction SilentlyContinue
$result.Output = Get-Content -LiteralPath $filePath -Raw -ErrorAction SilentlyContinue
} catch {
$result.Error = $_
} finally {
Expand Down