Skip to content

Restore SetBreakpoints API #11622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 6 commits into from
Jan 30, 2020
Merged

Restore SetBreakpoints API #11622

TravisEz13 merged 6 commits into from
Jan 30, 2020

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Jan 17, 2020

#11312 changed the SetBreakpoint() API in a breaking way. This PR restores the original API while continuing to make the new one available.

Tooling will be impacted by not crashing when targeting the SetBreakpoints API across PowerShell versions.

NOTE #11312 adds default parameters to other APIs (not broken since they were only added in the 7.0 timeframe). For compatibility it would be favourable to turn those into overloads instead.

Services #11619.

PR Checklist

@ghost ghost assigned TravisEz13 Jan 17, 2020
@rjmholt rjmholt mentioned this pull request Jan 17, 2020
Closed
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jan 24, 2020 •
edited
Loading

NOTE #11312 adds default parameters to other APIs (not broken since they were only added in the 7.0 timeframe). For compatibility it would be favourable to turn those into overloads instead.

I spoke to @daxian-dbw about this back when I implemented #11312 and we decided that that breakage was fine.

@SteveL-MSFT SteveL-MSFT added this to the GA-consider milestone Jan 24, 2020
@rjmholt
Copy link
Collaborator Author

rjmholt commented Jan 27, 2020

we decided that that breakage was fine.

Well it's not mutually exclusive -- perhaps we can have both? Also, it feels like such a decision should be documented in either the PR or the extended commit message.

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jan 27, 2020

Yeah I thought that was captured but I guess not. I'll defer to @daxian-dbw for the right call here. I'm fine either way. Happy to add a comment on my old PR calling out the break.

@daxian-dbw
Copy link
Member

daxian-dbw commented Jan 27, 2020

I agree to have overloads.

@rjmholt rjmholt force-pushed the restoreapi-setbreakpoints branch from ca802ba to b06bbe4 Compare January 29, 2020 18:26
@TravisEz13
Copy link
Member

TravisEz13 commented Jan 29, 2020

Please review @PaulHigin

@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 30, 2020
TravisEz13
TravisEz13 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as maintainer

@TravisEz13 TravisEz13 changed the title Restore SetBreakpoints API Restore SetBreakpoints API Jan 30, 2020
@TravisEz13 TravisEz13 merged commit f0fe356 into PowerShell:master Jan 30, 2020
@daxian-dbw daxian-dbw modified the milestones: GA-consider, GA-approved Jan 31, 2020
@TravisEz13 TravisEz13 modified the milestones: GA-approved, 7.0.0 Feb 8, 2020
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
@rjmholt @TravisEz13
Restore SetBreakpoints API (PowerShell#11622)
ff0aaec 
* Restore SetBreakpoints API

* Remove default values in API methods

* Fix inheriting APIs

* Correct further comments

* Fix breakpoint API use issues

* Fix breakpoint API tests

# Conflicts:
#	test/powershell/SDK/Breakpoint.Tests.ps1
@ghost
Copy link

ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

+3 more reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt left review comments

@PoshChan PoshChan PoshChan left review comments

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

7 participants

@rjmholt @TylerLeonhardt @daxian-dbw @TravisEz13 @PaulHigin @PoshChan @SteveL-MSFT