Skip to content

Conversation

@xtqqczze
Copy link
Contributor

PR Summary

PSPathPath to PSPath in formatting xml

PR Context

PSPathPath is an invalid item property name

PR Checklist

@ghost ghost assigned TravisEz13 Jan 16, 2020
`PSPathPath` is an invalid item property name
@xtqqczze xtqqczze force-pushed the fix-Certificate_Format_Ps1Xml branch from e1692ab to 5262916 Compare January 16, 2020 15:41
.EndEntry()
.StartEntry(entrySelectedByType: new[] { "Microsoft.PowerShell.Commands.X509StoreLocation" })
.AddItemProperty(@"PSPathPath")
.AddItemProperty(@"PSPath")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tests for this? If no we should add.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 17, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 17, 2020
@iSazonov
Copy link
Collaborator

@xtqqczze Please don't edit/trim PR Checklist.

@TravisEz13 TravisEz13 changed the title Fix certificate_format_ps1.xml Update PSPath in certificate_format_ps1.xml Feb 3, 2020
@TravisEz13 TravisEz13 changed the title Update PSPath in certificate_format_ps1.xml Update PSPath in certificate_format_ps1.xml Feb 3, 2020
@TravisEz13 TravisEz13 merged commit c73a599 into PowerShell:master Feb 3, 2020
@xtqqczze xtqqczze deleted the fix-Certificate_Format_Ps1Xml branch February 4, 2020 23:34
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants