Skip to content

Add new tests for Get-ChildItem (FileSystemProvider) #11602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 5 commits into from
Feb 12, 2020
Merged

Add new tests for Get-ChildItem (FileSystemProvider) #11602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87e8739
Add new tests for Get-ChildItem (FileSystemProvider)
iSazonov Jan 16, 2020
0fc8473
Use OS specific path separator
iSazonov Jan 16, 2020
82687d6
Add tests for Get-ChildItem -Name and symbolic links
iSazonov Jan 17, 2020
9a1972f
Add tests for Get-ChildItem -Depth
iSazonov Jan 20, 2020
e52488a
Address feedback
iSazonov Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,11 +570,26 @@ Describe "Hard link and symbolic link tests" -Tags "CI", "RequireAdminOnWindows"
$ci[1].Name | Should -MatchExactly $filenamePattern
$ci[2].Name | Should -MatchExactly $filenamePattern
}
It "Get-ChildItem -Name gets content of linked-to directory" {
# The test depends on the files created in previous test:
#$filenamePattern = "AlphaFile[12]\.txt"
#New-Item -ItemType SymbolicLink -Path $alphaLink -Value $alphaDir
$ci = Get-ChildItem $alphaLink -Name
$ci.Count | Should -Be 3
$ci[1] | Should -MatchExactly $filenamePattern
$ci[2] | Should -MatchExactly $filenamePattern
}
It "Get-ChildItem does not recurse into symbolic links not explicitly given on the command line" {
New-Item -ItemType SymbolicLink -Path $betaLink -Value $betaDir
$ci = Get-ChildItem $alphaLink -Recurse
$ci.Count | Should -BeExactly 7
}
It "Get-ChildItem -Name does not recurse into symbolic links not explicitly given on the command line" -Pending {
# The test depends on the files created in previous test:
#New-Item -ItemType SymbolicLink -Path $betaLink -Value $betaDir
$ci = Get-ChildItem $alphaLink -Recurse -Name
$ci.Count | Should -BeExactly 7 # returns 10 - unexpectly recurce in link-alpha\link-Beta. See https://github.com/PowerShell/PowerShell/issues/11614
}
It "Get-ChildItem will recurse into symlinks given -FollowSymlink, avoiding link loops" {
New-Item -ItemType Directory -Path $gammaDir
New-Item -ItemType SymbolicLink -Path $uponeLink -Value $betaDir
Expand All @@ -584,6 +599,16 @@ Describe "Hard link and symbolic link tests" -Tags "CI", "RequireAdminOnWindows"
$ci.Count | Should -BeExactly 13
$w.Count | Should -BeExactly 3
}
It "Get-ChildItem -Name will recurse into symlinks given -FollowSymlink, avoiding link loops" -Pending {
# The test depends on the files created in previous test:
# New-Item -ItemType Directory -Path $gammaDir
# New-Item -ItemType SymbolicLink -Path $uponeLink -Value $betaDir
# New-Item -ItemType SymbolicLink -Path $uptwoLink -Value $alphaDir
# New-Item -ItemType SymbolicLink -Path $omegaLink -Value $omegaDir
$ci = Get-ChildItem -Path $alphaDir -FollowSymlink -Recurse -WarningVariable w -WarningAction SilentlyContinue -Name # unexpectly dead cycle. See https://github.com/PowerShell/PowerShell/issues/11614
$ci.Count | Should -BeExactly 13
$w.Count | Should -BeExactly 3
}
}

Context "Remove-Item and hard/symbolic links" {
Expand Down
Loading