-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Format-Hex - Fix Grouping Behaviour with Boolean values #11587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not flushing the input buffer immediately when a different type is encountered. This caused some odd behaviour when piping in a mix of bools and ints. Fix is to immediately flush the input buffer when the incoming object is a different type than anything we have buffered.
iSazonov
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
a7e7381 to
74b2569
Compare
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Show resolved
Hide resolved
74b2569 to
fab4ef2
Compare
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
fab4ef2 to
6fa1ead
Compare
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
6fa1ead to
f39fc4b
Compare
Collaborator
Author
|
OK that should do it for the tests this time 'round. Very much starting to feel like we need to rewrite those ones at some point. Anyhow, should be good to go once CI passes @SteveL-MSFT |
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jan 15, 2020
...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Outdated
Show resolved
Hide resolved
f39fc4b to
904bdeb
Compare
iSazonov
approved these changes
Jan 15, 2020
SteveL-MSFT
approved these changes
Jan 23, 2020
|
🎉 Handy links: |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We were not flushing the input buffer immediately when a different type is encountered. This caused some odd behaviour when piping in a mix of bools and ints. Fix is to immediately flush the input buffer when the incoming object is a different type than anything we have buffered.
This PR also contains a commit which cuts down the visual representation of booleans to 1 byte.
Marshal.SizeOf()actually returns4for boolean values, since .NET pads Boolean values apparently to make them easier to compare with on modern processors which tend to be optimized for 32 or 64 bit values. See this SO question for reference.I modified some of the logic to skip checking the size if the input value is Boolean, and simply represent it with an
0x1or0x0byte to keep the representation as effective as possible.PR Context
Resolves #11585
/cc @SteveL-MSFT @iSazonov
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.