Skip to content

Check state and report reason if it's not "opened" #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 6 commits into from
Jan 30, 2020
Merged

Check state and report reason if it's not "opened" #11574

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55625f8
wait for runspace to be opened
TylerLeonhardt Jan 14, 2020
a90be10
check state and report if it's not Opened
TylerLeonhardt Jan 14, 2020
504d73c
null check for Dispose
TylerLeonhardt Jan 14, 2020
bd3ff4d
( )
TylerLeonhardt Jan 14, 2020
64bf9f7
use Trace-Command
TylerLeonhardt Jan 14, 2020
b06ab3e
don't use experimental syntax
TylerLeonhardt Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,22 @@ Describe "Enter-PSHostProcess tests" -Tag Feature {

$npInfo = [System.Management.Automation.Runspaces.NamedPipeConnectionInfo]::new($pwshId)
$rs = [runspacefactory]::CreateRunspace($npInfo)
$rs.Open()

# Try to open the runspace while tracing.
$splat = @{
Name = "RunspaceInit"
Expression = {$Input.Open()}
PSHost = $true
ListenerOption = [System.Diagnostics.TraceOptions]::Callstack
FilePath = "$TestDrive/$([System.IO.Path]::GetRandomFileName()).log"
InputObject = $rs
}
Trace-Command @splat

# If opening the runspace fails, then print out the trace with the callstack
Wait-UntilTrue { $rs.RunspaceStateInfo.State -eq [System.Management.Automation.Runspaces.RunspaceState]::Opened } |
Should -BeTrue -Because (get-content $splat.FilePath -Raw)

$ps = [powershell]::Create()
$ps.Runspace = $rs
$ps.AddScript('$pid')
Expand All @@ -152,8 +167,14 @@ Describe "Enter-PSHostProcess tests" -Tag Feature {

$result | Should -Be $pwshId -Because $errorMsg
} finally {
$rs.Dispose()
$ps.Dispose()
# Clean up disposables
if ($rs) {
$rs.Dispose()
}

if ($ps) {
$ps.Dispose()
}
}
}
}
Expand Down