Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jan 12, 2020

PR Summary

Set-StrictMode -Version 3.0

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Jan 12, 2020
@xtqqczze xtqqczze changed the title Specify exact StrictMode version instead of 'Latest' Apply StrictMode version 3.0' Jan 12, 2020
@xtqqczze xtqqczze changed the title Apply StrictMode version 3.0' Apply StrictMode version 3.0 Jan 12, 2020
@xtqqczze xtqqczze changed the title Apply StrictMode version 3.0 [WIP]Apply StrictMode version 3.0 Jan 13, 2020
@xtqqczze xtqqczze mentioned this pull request Jan 13, 2020
8 tasks
* Set strict mode to version 3.0
* Fix VariableIsUndefined errors
* Fix PropertyNotFoundStrict errors
@xtqqczze xtqqczze changed the title [WIP]Apply StrictMode version 3.0 Set StrictMode version 3.0 Jan 15, 2020
@xtqqczze
Copy link
Contributor Author

CodeFactor issues are preexisting.

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 31, 2020
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 31, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Jan 31, 2020
Address @TravisEz13 review

Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 1, 2020
Address @TravisEz13 review

Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com>
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 1, 2020

CodeFactor issues are preexisting.

@TravisEz13 TravisEz13 changed the title Set StrictMode version 3.0 Set StrictMode version 3.0 Feb 3, 2020
@TravisEz13 TravisEz13 merged commit 2014ce6 into PowerShell:master Feb 3, 2020
@TravisEz13
Copy link
Member

@xtqqczze Thanks for the contribution

@xtqqczze xtqqczze deleted the set-strictmode branch February 4, 2020 23:33
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants