Skip to content

Avoid variable names that conflict with automatic variables part 2 #11559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Jan 13, 2020
Merged

Avoid variable names that conflict with automatic variables part 2 #11559

iSazonov merged 3 commits into from
Jan 13, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jan 11, 2020

PR Summary

PR Context

Variable names such as $error cause a PSScriptAnalyzer rule violation of type AvoidAssignmentToAutomaticVariable.

PR Checklist

@xtqqczze xtqqczze force-pushed the AvoidAssignmentToAutomaticVariable2 branch 2 times, most recently from 430fee5 to d0f77a4 Compare January 11, 2020 18:33
@xtqqczze xtqqczze force-pushed the AvoidAssignmentToAutomaticVariable2 branch from d0f77a4 to 375cf08 Compare January 11, 2020 22:36
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jan 11, 2020

@anmenaga can you review?

iSazonov
iSazonov reviewed Jan 13, 2020
View reviewed changes
@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 13, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 13, 2020
@iSazonov iSazonov merged commit 7d0e9f1 into PowerShell:master Jan 13, 2020
@iSazonov iSazonov changed the title Avoid variable names that conflict with automatic variables part2 Avoid variable names that conflict with automatic variables part 2 Jan 13, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 13, 2020

@xtqqczze Thanks for your contribution!

@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze deleted the AvoidAssignmentToAutomaticVariable2 branch April 6, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan