Update pester syntax to v4 #11544
Merged
Update pester syntax to v4 #11544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtqqczze
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
Collaborator
|
@xtqqczze It is a huge PR. Please to split it on some small PR. It is easy to fix and review. |
xtqqczze
force-pushed
the
update-pester-syntax
branch
from
01dbaea to
c4de7ba
Compare
```powershell $_ -ireplace '\s?\|\s?should\b',' | Should' ```
```powershell $_ -ireplace '(\| Should) not\b','$1 -Not' ```
```powershell $_ -ireplace '(\| Should(?: -Not)?) -?be\b','$1 -Be' ```
$_ -ireplace '(\| Should(?: -Not)?) -?beexactly\b','$1 -BeExactly'
```powershell $_ -ireplace '(\| Should(?: -Not)?) -?begreaterthan\b','$1 -BeGreaterThan' ```
```powershell $_ -ireplace '(\| Should(?: -Not)?) -Be\s\$?true\b','$1 -BeTrue' ```
```powershell $_ -ireplace '(\| Should(?: -Not)?) -Be\s\$?false\b','$1 -BeFalse' ```
```powershell $_ -ireplace '(\| Should(?: -Not)?)\s-?match\b','$1 -Match' ```
```powershell $_ -ireplace '(\| Should(?: -Not)?)\s-?throw\b','$1 -Throw' ```
```powershell $_ -ireplace '(\| Should(?: -Not)?)\s-?benullorempty\b','$1 -BeNullOrEmpty' ```
```powershell $_ -ireplace '\s-because\b',' -Because' ```
xtqqczze
force-pushed
the
update-pester-syntax
branch
from
c4de7ba to
e829996
Compare
Contributor
Author
|
@iSazonov Removed some commits and rebased, PR is ready for merge. |
iSazonov
added
the
CL-Test
iSazonov
approved these changes
Jan 11, 2020
Collaborator
|
@xtqqczze Thanks for your contribution! |
|
🎉 Handy links: |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
Pester documentation for 4.x recommends using Should -Be instead of Should Be syntax.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.