Update Debian Install Script To Support Debian 10 #11540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
TravisEz13
reviewed
Jan 9, 2020
tools/installpsh-debian.sh
Outdated
Member
There was a problem hiding this comment.
Suggested change
| 8|9|10) | |
| 8|9|10|11) |
TravisEz13
added
the
CL-BuildPackaging
Support for installing pwsh on Debian 10 was added in PowerShell#11236, but the install script for Debian was not updated. This resulted in an error when running the install script that claimed the distro was not supported. This change simply adds `10` to the collection of supported distro's. I have tested that the script will now successfully install powershell preview 7 on a Debian 10 machine. Fix PowerShell#11539
RandomNoun7
force-pushed
the
update-installpsh-debian-script
branch
from
5d0a969 to
c2d0424
Compare
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@TravisEz13, this is the reminder you requested 1 hour ago |
TravisEz13
approved these changes
Jan 12, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Support for installing pwsh on Debian 10 was added in #11236, but the
install script for Debian was not updated. This resulted in an error
when running the install script that claimed the distro was not
supported.
This change simply adds
10to the collection of supported distro's.I have tested that the script will now successfully install powershell
preview 7 on a Debian 10 machine.
Fix #11539
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.