Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jan 8, 2020

PR Summary

Currently, MSIX has two products: PowerShellPreview and PowerShell. The current code looks for preview in the version to determine it is a preview release which misses rc releases. The fix is to check for a - indicating a semver label which means not stable. Second, the product version relies on the semver label to create the revision, so 7.0.0-rc.2 becomes 7.0.2, but this conflicts with 7.0.0-preview.2 which is also 7.0.2 and would also be older than 7.0.0-preview.6 which is 7.0.6. Fix is to increase the revision to the 100 range so, 7.0.0-rc.2 becomes 7.0.102. Since non-preview releases are a separate product, the versioning won't conflict with a serviced 7.0 release.

PR Checklist

@TravisEz13
Copy link
Member

@adityapatwardhan Can you review as well?

@TravisEz13 TravisEz13 merged commit f61c0d4 into PowerShell:master Jan 9, 2020
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 14, 2020
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 15, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log MustHave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants