Skip to content

Update the breaking change definition #11516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 1 commit into from
Jan 9, 2020
Merged

Update the breaking change definition #11516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/maintainers/best-practice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
1. The optional extended description is required for feature-work PRs, or regular PRs with breaking changes.
For other PRs, it's not required but good to have based on the judgement of the maintainer.

- If a PR introduces breaking changes,
- If a PR introduces breaking changes from the previous stable release,
make sure you put the tag `[breaking change]` at the first line of the extended description,
and start the description text from the second line.

Expand Down