Skip to content

Remove RequireLicenseAcceptance default value #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 3 commits into from
Jan 7, 2020
Merged

Remove RequireLicenseAcceptance default value #11512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d794e1
Remove RequireLicenseAcceptance default value
ThomasNieto Jan 7, 2020
9a7d2e6
Update RequireLicenseAcceptance test
ThomasNieto Jan 7, 2020
3bc4204
Fix RequireLicenseAcceptance tests
ThomasNieto Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ public object PrivateData
/// Gets or sets whether or not the module requires explicit user acceptance for install/update/save.
/// </summary>
[Parameter]
public SwitchParameter RequireLicenseAcceptance { get; set; } = true;
public SwitchParameter RequireLicenseAcceptance { get; set; }

/// <summary>
/// Gets or sets the external module dependencies.
Expand Down
1 change: 1 addition & 0 deletions test/powershell/engine/Module/NewModuleManifest.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Describe "New-ModuleManifest basic tests" -tags "CI" {
$module.Name | Should -BeExactly "test"
$module.ModuleType | Should -BeExactly "Manifest"
$module.Version | Should -BeExactly "0.0.1"
$module.PrivateData.PSData.RequireLicenseAcceptance | Should -BeNullOrEmpty
}

It "Verify manifest fields 2" {
Expand Down