Skip to content

Conversation

@PaulHigin
Copy link
Contributor

PR Summary

One SSH remoting test was failing on some platforms because the returned error id string is slightly different.

PR Context

Depending on platform and error path the returned error id string can be '2100,PSSessionOpenFailed' or 'PSSessionOpenFailed'.
Fix is to update test to just look for the expected 'PSSessionOpenFailed'.

PR Checklist

@ghost ghost assigned TravisEz13 Jan 6, 2020
@adityapatwardhan
Copy link
Member

@PoshChan please rebuild all

@PoshChan
Copy link
Collaborator

PoshChan commented Jan 7, 2020

@adityapatwardhan, successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

@adityapatwardhan adityapatwardhan mentioned this pull request Jan 7, 2020
14 tasks
@adityapatwardhan adityapatwardhan merged commit f22bad1 into PowerShell:master Jan 7, 2020
@PaulHigin PaulHigin deleted the fix-ssh-tests branch January 8, 2020 16:14
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@daxian-dbw daxian-dbw added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 15, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants