Skip to content

Conversation

@rkeithhill
Copy link
Collaborator

@rkeithhill rkeithhill commented Dec 29, 2019

PR Summary

This improves the fg/bg contrast of the progress colors which improves readability in various color schemes. The current colors are particularly poor in the One Half Dark color scheme. The screenshots below show the before (left) and after (right) for both the Campbell (default) color scheme on top and the One Half Dark color scheme on the bottom:

image

PR Context

This addresses a comment I made on issue #10780, that the progress fg/bg contrast is not great particularly for the One Half Dark color scheme. FWIW I'm not set on these particular colors. It's just that black on yellow provides good contrast in "most" color schemes whereas yellow on dark cyan does not.

We could consider using RGB colors to "fix" the fg/bg progress colors on hosts that SupportsVirtualTerminal. Using ConsoleColor indices is somewhat problematic as you can see above. That would mean the progress colors might not "fit" the current color scheme but OTOH the progress text would have good contrast for better readability. Also, this represents more code change since the current host colors take only ConsoleColors.

PR Checklist

@iSazonov
Copy link
Collaborator

I believe it is a task exclusively for MSFT usability engineers.

@daxian-dbw daxian-dbw added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Mar 13, 2020
@daxian-dbw
Copy link
Member

daxian-dbw commented Mar 13, 2020

This is a UX change. Better let the committee weigh in.

@SteveL-MSFT
Copy link
Member

@PowerShell/powershell-committee reviewed this, ideally the colors should be configurable, but we would not block this PR to make that happen as that is a bigger work item. We'll follow up with the Accessibility experts to confirm the colors meet requirements but we are open to a change

@SteveL-MSFT SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Apr 2, 2020
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed using the Color Contrast Analyzer tool the proposed colors meet accessibility requirements

@iSazonov iSazonov added this to the 7.1.0-preview.2 milestone Apr 3, 2020
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 3, 2020
@iSazonov iSazonov merged commit 8d71154 into PowerShell:master Apr 3, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

🎉v7.1.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 26, 2020

This made changes to ConsoleHost. Why was the first box checked on affecting tooling?

Any user-facing change to ConsoleHost affects PSES which is a different host.

@iSazonov
Copy link
Collaborator

Why was the first box checked on affecting tooling?

After these check boxed was added in PR template I ask how we will do the checks and answer was - manually by owners. So I never set the check boxes.
Make sense to add you to ConsoleHost file owners? Github will automatically add you in reviewer list.

@TylerLeonhardt
Copy link
Member

Make sense to add you to ConsoleHost file owners? Github will automatically add you in reviewer list.

I'm fine with this... but I'll let the maintainers decide.

@iSazonov iSazonov mentioned this pull request Apr 28, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants