-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Change progress fg & bg colors to provide better contrast #11455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change progress fg & bg colors to provide better contrast #11455
Conversation
|
I believe it is a task exclusively for MSFT usability engineers. |
|
This is a UX change. Better let the committee weigh in. |
|
@PowerShell/powershell-committee reviewed this, ideally the colors should be configurable, but we would not block this PR to make that happen as that is a bigger work item. We'll follow up with the Accessibility experts to confirm the colors meet requirements but we are open to a change |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed using the Color Contrast Analyzer tool the proposed colors meet accessibility requirements
|
🎉 Handy links: |
|
This made changes to ConsoleHost. Why was the first box checked on affecting tooling? Any user-facing change to ConsoleHost affects PSES which is a different host. |
After these check boxed was added in PR template I ask how we will do the checks and answer was - manually by owners. So I never set the check boxes. |
I'm fine with this... but I'll let the maintainers decide. |
PR Summary
This improves the fg/bg contrast of the progress colors which improves readability in various color schemes. The current colors are particularly poor in the One Half Dark color scheme. The screenshots below show the before (left) and after (right) for both the Campbell (default) color scheme on top and the One Half Dark color scheme on the bottom:
PR Context
This addresses a comment I made on issue #10780, that the progress fg/bg contrast is not great particularly for the One Half Dark color scheme. FWIW I'm not set on these particular colors. It's just that black on yellow provides good contrast in "most" color schemes whereas yellow on dark cyan does not.
We could consider using RGB colors to "fix" the fg/bg progress colors on hosts that
SupportsVirtualTerminal. UsingConsoleColorindices is somewhat problematic as you can see above. That would mean the progress colors might not "fit" the current color scheme but OTOH the progress text would have good contrast for better readability. Also, this represents more code change since the current host colors take only ConsoleColors.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.