Skip to content

Allow error 504 (Gateway Timeout) in markdown-link tests #11439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 4 commits into from
Jan 6, 2020
Merged

Allow error 504 (Gateway Timeout) in markdown-link tests #11439

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e372118
Add error 504 (Gateway Timeout) to allowedFailures
xtqqczze Dec 27, 2019
1a09123
Update comments
xtqqczze Dec 27, 2019
12a20fc
Improve comments
xtqqczze Dec 27, 2019
4d0ac5c
Use HttpStatusCode type
xtqqczze Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/common/markdown/markdown-link.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,10 @@ Describe "Verify Markdown Links" {

# there could be multiple reasons why a failure is ok
# check against the allowed failures
# 503 = service temporarily unavailable
$allowedFailures = @( 503 )
$allowedFailures = [System.Net.HttpStatusCode[]](
503, # Service Unavailable
504 # Gateway Timeout
)

$prefix = $url.Substring(0,7)

Expand Down