Skip to content

Include url in the markdown-links test error message #11438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 9 commits into from
Jan 3, 2020
Merged

Include url in the markdown-links test error message #11438

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec8f170
Include url in markdown-links tests error message
xtqqczze Dec 27, 2019
e634d6f
Don't push to stack with throw
xtqqczze Dec 27, 2019
5c22057
Revert "Don't push to stack with throw"
xtqqczze Dec 27, 2019
1f60377
Invoke ThrowTerminatingError
xtqqczze Dec 27, 2019
91848ff
Revert "Invoke ThrowTerminatingError"
xtqqczze Dec 27, 2019
359b948
Test
xtqqczze Dec 27, 2019
19721c3
Revert "Test"
xtqqczze Dec 27, 2019
ee2b932
Specify exception to catch
xtqqczze Dec 27, 2019
240c949
Catch HttpResponseException
xtqqczze Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/common/markdown/markdown-link.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ Describe "Verify Markdown Links" {
{
$null = Invoke-WebRequest -uri $url -RetryIntervalSec 10 -MaximumRetryCount 6
}
catch
catch [Microsoft.PowerShell.Commands.HttpResponseException]
{
if ( $allowedFailures -notcontains $_.Exception.Response.StatusCode ) {
throw "retry of URL failed with error: $($_.Exception.Message)"
throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
}
}
}
Expand Down