Skip to content

Include url in the markdown-links test error message #11438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 9 commits into from
Jan 3, 2020
Merged

Include url in the markdown-links test error message #11438

anmenaga merged 9 commits into from
Jan 3, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 27, 2019

PR Summary

Include the failed url in the markdown-links test error message

PR Context

Including url aids diagnosis in Azure DevOps.

PR Checklist

@ghost ghost assigned anmenaga Dec 27, 2019
@xtqqczze xtqqczze mentioned this pull request Dec 27, 2019
Closed
@xtqqczze xtqqczze changed the title Include url in the markdown-links test error message [WIP]Include url in the markdown-links test error message Dec 27, 2019
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 27, 2019

2019-12-27T03:44:25.7287100Z at , /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 112
2019-12-27T03:44:25.7867441Z invoke-pester : Exception calling "LeaveTestGroup" with "2" argument(s): "TestGroups stack corrupted: Expected name/hint of '/home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1','Script'. Found 'Verify links in /home/vsts/work/1/s/README.md', 'Context'."

@iSazonov iSazonov requested a review from TravisEz13 December 27, 2019 13:56
@xtqqczze xtqqczze changed the title [WIP]Include url in the markdown-links test error message Include url in the markdown-links test error message Dec 27, 2019
@anmenaga anmenaga added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 3, 2020
@anmenaga anmenaga added this to the 7.1.0-preview.1 milestone Jan 3, 2020
@anmenaga anmenaga merged commit 08d6be9 into PowerShell:master Jan 3, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 3, 2020

@xtqqczze Thanks for your contribution!

@xtqqczze xtqqczze deleted the markdown-link branch January 8, 2020 11:28
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@anmenaga anmenaga

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @anmenaga