Skip to content

Use CIM cmdlets instead of WMI cmdlets in tests #11423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 6 commits into from
Jan 3, 2020
Merged

Use CIM cmdlets instead of WMI cmdlets in tests #11423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7d995f
Use CIM cmdlets instead of WMI cmdlets in tests
xtqqczze Dec 23, 2019
0529ea9
Fix access denied error
xtqqczze Dec 23, 2019
c38eaea
Use ClientOnly parameter on New-CimInstance
xtqqczze Dec 26, 2019
ff9b9d1
Refactor New-CimInstance cmdlet tests
xtqqczze Dec 27, 2019
0461d97
Fix Cdxml tests
xtqqczze Dec 27, 2019
58c2ddd
Empty commit for CI
xtqqczze Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/powershell/Language/Scripting/Indexer.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ Describe 'Tests for indexers' -Tags "CI" {
$hashtable["Hello There"] | Should -BeNullOrEmpty
}

It 'Wmi object implements an indexer' -Skip:$IsCoreCLR {
It 'CimClass implements an indexer' -Skip:(-not $IsWindows) {

$service = Get-WmiObject -List -Amended Win32_Service
$service = Get-CimClass -ClassName Win32_Service

$service.Properties["DisplayName"].Name | Should -BeExactly 'DisplayName'
$service.CimClassProperties["DisplayName"].Name | Should -BeExactly 'DisplayName'
}

It 'Accessing a Indexed property of a wmi object that does not exist should return $NULL' -skip:$IsCoreCLR {
It 'Accessing a Indexed property of a CimClass that does not exist should return $NULL' -Skip:(-not $IsWindows) {

$service = Get-WmiObject -List -Amended Win32_Service
$service.Properties["Hello There"] | Should -BeNullOrEmpty
$service = Get-CimClass -ClassName Win32_Service
$service.CimClassProperties["Hello There"] | Should -BeNullOrEmpty
}

It 'ITuple implementations can be indexed' {
Expand Down
40 changes: 22 additions & 18 deletions test/powershell/Language/Scripting/OrderedAttributeForHashTables.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.
Describe 'Test for cmdlet to support Ordered Attribute on hash literal nodes' -Tags "CI" {
BeforeAll {
If (-not $IsCoreCLR) {
Get-WmiObject -Query "select * from win32_environment where name='TestWmiInstance'" | Remove-WmiObject
}
}
AfterAll {
If (-not $IsCoreCLR) {
Get-WmiObject -Query "select * from win32_environment where name='TestWmiInstance'" | Remove-WmiObject
}
}

It 'New-Object - Property Parameter Must take IDictionary' {
$a = new-object psobject -property ([ordered]@{one=1;two=2})
$a | Should -Not -BeNullOrEmpty
Expand Down Expand Up @@ -45,15 +34,30 @@ Describe 'Test for cmdlet to support Ordered Attribute on hash literal nodes' -T
It '$a should not be $null' { $script:a | Should -Not -BeNullOrEmpty }
}

It 'Set-WmiInstance cmdlet - Argument parameter must take IDictionary' -skip:$IsCoreCLR {
Context 'New-CimInstance cmdlet' {
BeforeAll {
If ($IsWindows) {
Get-CimInstance -ClassName Win32_Environment -Filter "name='TestCimInstance'" | Remove-CimInstance
}
}
AfterAll {
If ($IsWindows) {
Get-CimInstance -ClassName Win32_Environment -Filter "name='TestCimInstance'" | Remove-CimInstance
}
}

$script:a = $null
It 'Property parameter must take IDictionary' -Skip:(-not $IsWindows) {

{ $script:a = set-wmiinstance -class win32_environment -argument ([ordered]@{Name="TestWmiInstance";
VariableValue="testvalu234e";
UserName="<SYSTEM>"}) } | Should -Not -Throw
$script:a | Should -Not -BeNullOrEmpty
$script:a.Name | Should -BeExactly "TestWmiInstance"
$script:a = $null

{ $script:a = New-CimInstance -ClassName Win32_Environment -Property ([ordered]@{
Name="TestCimInstance";
VariableValue="testvalu234e";
UserName=[System.Environment]::UserName
}) -ClientOnly } | Should -Not -Throw
$script:a | Should -Not -BeNullOrEmpty
$script:a.Name | Should -BeExactly "TestCimInstance"
}
}

Context 'Select-Object cmdlet - Property parameter (Calculated properties) must take IDictionary' {
Expand Down