Skip to content

Use CIM cmdlets instead of WMI cmdlets in tests #11423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 6 commits into from
Jan 3, 2020
Merged

Use CIM cmdlets instead of WMI cmdlets in tests #11423

adityapatwardhan merged 6 commits into from
Jan 3, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 23, 2019 •
edited
Loading

PR Summary

PR Context

  • WMI cmdlets were removed in PSVersion 6
  • Fixes PSScriptAnalyzer rule violation AvoidUsingWMICmdlet

PR Checklist

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 23, 2019

2019-12-23T04:44:38.1811873Z New-CimInstance: D:\a\1\s\test\powershell\Language\Scripting\OrderedAttributeForHashTables.Tests.ps1:52
2019-12-23T04:44:38.1815776Z Line |
2019-12-23T04:44:38.1822496Z 52 | … $script:a = New-CimInstance -ClassName Win32_Environment -Property ([ …
2019-12-23T04:44:38.1823774Z
2019-12-23T04:44:38.1827509Z | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-12-23T04:44:38.1832703Z | Access denied

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 27, 2019

2019-12-27T00:53:00.2202932Z [-] https://gitter.im/PowerShell/PowerShell?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge should work 269.56s
2019-12-27T00:53:00.2787888Z RuntimeException: retry of URL failed with error: Response status code does not indicate success: 504 (GATEWAY_TIMEOUT).
2019-12-27T00:53:00.2790901Z at , /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 117

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 27, 2019 •
edited
Loading

PowerShell-CI-static-analysis was broken by a Gitter outage.

Issue opened: #11437

@xtqqczze xtqqczze changed the title [WIP]Use CIM cmdlets instead of WMI cmdlets in tests Use CIM cmdlets instead of WMI cmdlets in tests Dec 27, 2019
@adityapatwardhan adityapatwardhan merged commit ee71081 into PowerShell:master Jan 3, 2020
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jan 3, 2020

@xtqqczze Thank you for your contribution!

@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 3, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.1 milestone Jan 3, 2020
@xtqqczze xtqqczze deleted the AvoidUsingWMICmdlet branch January 22, 2020 16:23
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @adityapatwardhan