Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Dec 20, 2019

PR Summary

In one of the previous PRs for ConciseView, System.Exception was incorrectly added to the typenames handled by the ErrorRecord formatting. This results in just Exception objects written to the console to not be rendered since the ErrorRecord formatting didn't handle this situation. Fix is to remove the line to add that type putting it back to how it was previously. Also made the handling of ErrorRecord a bit more robust just in case Exception.Message doesn't exist nor a Message property.

PR Context

Fix #11413

PR Checklist

@SteveL-MSFT SteveL-MSFT added this to the GA-consider milestone Dec 20, 2019
@SteveL-MSFT SteveL-MSFT requested a review from iSazonov December 20, 2019 21:39
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 21, 2019
@iSazonov iSazonov merged commit 5b42126 into PowerShell:master Dec 21, 2019
@SteveL-MSFT SteveL-MSFT deleted the concise-exception branch December 23, 2019 18:56
daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
* In one of the previous PRs for ConciseView, System.Exception was incorrectly added to the typenames handled by the ErrorRecord formatting. This results in just Exception objects written to the console to not be rendered since the ErrorRecord formatting didn't handle this situation. Fix is to remove the line to add that type putting it back to how it was previously. 

* Also made the handling of ErrorRecord a bit more robust just in case Exception.Message doesn't exist nor a Message property.
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting for unthrown exception incorrect

4 participants