Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Dec 18, 2019

PR Summary

If a script uses tabs instead of spaces, the calculation for the caret for error position is wrong. This is because the InvocationInfo member treats tabs as a single character. However, the pre-rendered PositionMessage member already takes care of the tabs and the correct index so the change is to rely on parsing that to get the information rather than the existing members.

Before and after shot:
img

PR Context

Fix #11394
Fix #10760

PR Checklist

@ghost ghost assigned daxian-dbw Dec 18, 2019
@SteveL-MSFT SteveL-MSFT requested a review from anmenaga December 18, 2019 17:53
@SteveL-MSFT SteveL-MSFT added this to the GA-consider milestone Dec 18, 2019
@kborowinski
Copy link
Contributor

@SteveL-MSFT : Sorry for off-topic but, oh man, you are fast!

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 18, 2019
@daxian-dbw daxian-dbw merged commit a1066ac into PowerShell:master Dec 19, 2019
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConciseView formatting is broken when script body is indented with tabs Long error message in ConciseView

5 participants