Skip to content

Add new test for Format-Custom to avoid data loss #11393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jun 30, 2020
Merged

Add new test for Format-Custom to avoid data loss #11393

iSazonov merged 1 commit into from
Jun 30, 2020

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 18, 2019 •
edited
Loading

PR Summary

Add new test.

PR Context

See #11342 for more information

PR Checklist

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Dec 18, 2019
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Dec 18, 2019
@iSazonov iSazonov requested a review from SteveL-MSFT December 18, 2019 08:05
@iSazonov iSazonov self-assigned this Dec 18, 2019
@iSazonov
Copy link
Collaborator Author

iSazonov commented Mar 29, 2020

@SteveL-MSFT Please review or assign anybody.

@ghost ghost added the Review - Needed The PR is being reviewed label May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov requested a review from adityapatwardhan May 27, 2020 11:15
@iSazonov
Copy link
Collaborator Author

iSazonov commented Jun 11, 2020

@SteveL-MSFT @adityapatwardhan Could you please review?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 11, 2020
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jun 11, 2020

I will review this today. Thanks for your patience.

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 19, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan removed this from the 7.1.0-preview.4 milestone Jun 29, 2020
@iSazonov iSazonov merged commit 0c8aa53 into PowerShell:master Jun 30, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 30, 2020
@iSazonov iSazonov deleted the test-fmt-remarks branch June 30, 2020 04:39
@iSazonov iSazonov added this to the 7.1.0-preview.5 milestone Jun 30, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

🎉v7.1.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.5

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @adityapatwardhan @PoshChan @TravisEz13