Add trailing line number to filename for ConciseView #11391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some terminals can turn the script:line into a hyperlink, so adding the line number right after the filename allows it to be clickable and takes you to the line of the error instead of just the file. This does make the line number information redundant, but is not a big issue. Since this is similar to what users already saw in NormalView, they should understand what that number represents.
However, if we are running in vscode, it also understands script:line:col making the link click to the location of the error so we add column information only for vscode terminal.
PR Context
Fix #10877
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.