Skip to content

Fix test failing when UnixStat feature is disabled #11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Dec 20, 2019
Merged

Fix test failing when UnixStat feature is disabled #11370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Utility/Get-FormatData.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ Describe "Get-FormatData" -Tags "CI" {
$format.TypeNames | Should -HaveCount 2
Copy link
Collaborator

@PoshChan PoshChan Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-macos
Validate Update-Help from the Web for all PowerShell modules for user scope..Validate Update-Help for module 'PackageManagement' with scope as 'False'

Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.160.1/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

$format.TypeNames[0] | Should -BeExactly "System.IO.DirectoryInfo"
$format.TypeNames[1] | Should -BeExactly "System.IO.FileInfo"
$format.FormatViewDefinition | Should -HaveCount ($IsWindows ? 4 : 5)

$isUnixStatEnabled = $EnabledExperimentalFeatures -contains 'PSUnixFileStat'
$format.FormatViewDefinition | Should -HaveCount ( $isUnixStatEnabled ? 5 : 4)
}

It "Should return nothing for format data requiring '-PowerShellVersion 5.1' and not provided" {
Expand Down
3 changes: 2 additions & 1 deletion test/powershell/engine/ETS/TypeTable.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ Describe "Built-in type information tests" -Tag "CI" {
}

It "Should have correct number of built-in type items in type table" {
$types.Count | Should -BeExactly ($IsWindows ? 273 : 272)
$isUnixStatEnabled = $EnabledExperimentalFeatures -contains 'PSUnixFileStat'
$types.Count | Should -BeExactly ($isUnixStatEnabled ? 272 : 273)
}

It "Should have expected member info for 'System.Diagnostics.ProcessModule'" {
Expand Down