-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix test failing when UnixStat feature is disabled #11370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failing when UnixStat feature is disabled #11370
Conversation
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-FormatData.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-FormatData.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-FormatData.Tests.ps1
Show resolved
Hide resolved
|
close/open PR to re-trigger CIs. |
|
@PoshChan please rebuild all |
|
@adityapatwardhan, successfully started rebuild of |
|
|
||
| It "Can get format data requiring '-PowerShellVersion 5.1'" { | ||
| $format = Get-FormatData System.IO.FileInfo -PowerShellVersion 5.1 | ||
| $format.TypeNames | Should -HaveCount 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-macos
Validate Update-Help from the Web for all PowerShell modules for user scope..Validate Update-Help for module 'PackageManagement' with scope as 'False'
Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.160.1/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count|
@PoshChan please retry macos |
|
@adityapatwardhan, successfully started retry of |
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-FormatData.Tests.ps1
Show resolved
Hide resolved
|
@PoshChan please rebuild all |
|
@adityapatwardhan, successfully started rebuild of |
|
🎉 Handy links: |
PR Summary
Fixes #11357
PR Context
We check if the experimental feature is enabled before determining the expected value.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.