Skip to content

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Dec 17, 2019

PR Summary

Fixes #11357

PR Context

We check if the experimental feature is enabled before determining the expected value.

PR Checklist

@daxian-dbw daxian-dbw closed this Dec 17, 2019
@daxian-dbw daxian-dbw reopened this Dec 17, 2019
@daxian-dbw
Copy link
Member

close/open PR to re-trigger CIs.

@adityapatwardhan
Copy link
Member Author

@PoshChan please rebuild all

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux


It "Can get format data requiring '-PowerShellVersion 5.1'" {
$format = Get-FormatData System.IO.FileInfo -PowerShellVersion 5.1
$format.TypeNames | Should -HaveCount 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-macos
Validate Update-Help from the Web for all PowerShell modules for user scope..Validate Update-Help for module 'PackageManagement' with scope as 'False'

Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.160.1/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

@adityapatwardhan
Copy link
Member Author

@PoshChan please retry macos

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started retry of PowerShell-CI-macOS

@adityapatwardhan
Copy link
Member Author

@PoshChan please rebuild all

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

@adityapatwardhan adityapatwardhan merged commit ed27f36 into PowerShell:master Dec 20, 2019
@adityapatwardhan adityapatwardhan deleted the FixUnixStatTests branch December 20, 2019 23:32
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@daxian-dbw daxian-dbw added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 15, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing due to UnixStat feature being disabled

3 participants